Skip to content

fix(observability): add firewall and mcp artifacts, remove invalid parse param - #43658

Merged
pelikhan merged 2 commits into
mainfrom
copilot/fix-observability-firewall-mcp-artifacts
Jul 6, 2026
Merged

pelikhan merged 2 commits into
mainfrom
copilot/fix-observability-firewall-mcp-artifacts

Conversation

Copilot AI commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

The daily-observability-report workflow was silently producing 0% firewall and MCP gateway coverage because the required artifacts were never requested, and logs calls were failing parameter validation due to an unsupported parse field.

Changes

  • Added firewall and mcp artifact sets to both the broad fetch (Step 1.1) and targeted follow-up (Step 1.2) logs calls — ensures access.log, gateway.jsonl, and rpc-messages.jsonl are actually downloaded
  • Removed invalid parse: true parameter from both logs call parameter blocks — parse is not a valid parameter and caused validation failures
// Before
{
  "artifacts": ["usage", "agent", "detection"],
  "parse": true
}

// After
{
  "artifacts": ["usage", "agent", "detection", "firewall", "mcp"]
}

…rse param

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix observability by adding firewall and mcp artifacts and removing invalid parse param fix(observability): add firewall and mcp artifacts, remove invalid parse param Jul 6, 2026
Copilot AI requested a review from pelikhan July 6, 2026 01:53
@pelikhan
pelikhan marked this pull request as ready for review July 6, 2026 01:54
Copilot AI review requested due to automatic review settings July 6, 2026 01:54
@pelikhan
pelikhan merged commit c6bd90f into main Jul 6, 2026
@pelikhan
pelikhan deleted the copilot/fix-observability-firewall-mcp-artifacts branch July 6, 2026 01:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the daily-observability-report agentic workflow spec to ensure the MCP logs tool calls (a) request the firewall + MCP artifact sets needed for observability analysis and (b) stop passing an unsupported parse parameter that was causing tool argument validation failures.

Changes:

  • Removed the invalid parse: true field from both logs MCP tool parameter examples.
  • Expanded both logs calls’ artifacts lists to include firewall and mcp.
  • Recompiled the workflow, updating the generated .lock.yml metadata hash.
Show a summary per file
File Description
.github/workflows/daily-observability-report.md Fixes the MCP logs parameter examples by removing unsupported parse and requesting firewall/mcp artifacts.
.github/workflows/daily-observability-report.lock.yml Regenerated compiled workflow lock file reflecting the updated markdown content.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Low

Comment on lines 92 to +96
{
"workflow_name": "workflow-name",
"count": 100,
"start_date": "-7d",
"parse": true,
"artifacts": ["usage", "agent", "detection"]
"artifacts": ["usage", "agent", "detection", "firewall", "mcp"]
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.82.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[q] fix(observability): add firewall and mcp artifacts, remove invalid parse param

3 participants