fix(observability): add firewall and mcp artifacts, remove invalid parse param - #43658
Merged
Merged
Conversation
…rse param Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix observability by adding firewall and mcp artifacts and removing invalid parse param
fix(observability): add firewall and mcp artifacts, remove invalid parse param
Jul 6, 2026
pelikhan
marked this pull request as ready for review
July 6, 2026 01:54
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the daily-observability-report agentic workflow spec to ensure the MCP logs tool calls (a) request the firewall + MCP artifact sets needed for observability analysis and (b) stop passing an unsupported parse parameter that was causing tool argument validation failures.
Changes:
- Removed the invalid
parse: truefield from bothlogsMCP tool parameter examples. - Expanded both
logscalls’artifactslists to includefirewallandmcp. - Recompiled the workflow, updating the generated
.lock.ymlmetadata hash.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/daily-observability-report.md | Fixes the MCP logs parameter examples by removing unsupported parse and requesting firewall/mcp artifacts. |
| .github/workflows/daily-observability-report.lock.yml | Regenerated compiled workflow lock file reflecting the updated markdown content. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Low
Comment on lines
92
to
+96
| { | ||
| "workflow_name": "workflow-name", | ||
| "count": 100, | ||
| "start_date": "-7d", | ||
| "parse": true, | ||
| "artifacts": ["usage", "agent", "detection"] | ||
| "artifacts": ["usage", "agent", "detection", "firewall", "mcp"] |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This was referenced Aug 10, 2026
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
daily-observability-reportworkflow was silently producing 0% firewall and MCP gateway coverage because the required artifacts were never requested, andlogscalls were failing parameter validation due to an unsupportedparsefield.Changes
firewallandmcpartifact sets to both the broad fetch (Step 1.1) and targeted follow-up (Step 1.2)logscalls — ensuresaccess.log,gateway.jsonl, andrpc-messages.jsonlare actually downloadedparse: trueparameter from bothlogscall parameter blocks —parseis not a valid parameter and caused validation failures