Expose memory stores to `on.steps` in pre-activation for deterministic dispatch gating by Copilot · Pull Request #44015 · github/gh-aw

Copilot · 2026-07-07T12:13:31Z

on.steps executes in pre_activation, but memory stores were only restored in the agent job. This prevented deterministic pre-activation filters from using prior memory state without spending an LLM turn.

Pre-activation memory hydration
- Added buildPreActivationMemoryRestoreSteps and invoked it before injectPreActivationOnSteps.
- Pre-activation now restores/loads:
  - cache-memory (restore/setup path),
  - repo-memory (clone path),
  - comment-memory (materialized files via setup_comment_memory_files.cjs).
- Hydration is scoped to workflows that define on.steps.
Read-only behavior in pre-activation
- Reused restore/load paths only.
- No cache commit or repo push/write-back steps are introduced in pre_activation.
Coverage for memory-aware pre-activation dispatch
- Added an on_steps test case that validates:
  - memory restore/load steps are present in pre_activation,
  - they appear before the on.steps gate step,
  - write-back/commit steps are absent from pre_activation.

steps = c.buildPreActivationRolesBotsCmdSteps(data, steps)
steps = c.buildPreActivationMemoryRestoreSteps(data, steps) // restore memory before on.steps
steps, onStepIDs, err := c.injectPreActivationOnSteps(data, steps, customSteps)

Generated by 👨‍🍳 PR Sous Chef · 11.9 AIC · ⌖ 7.75 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · 3.94 AIC · ⌖ 7.46 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · 4.03 AIC · ⌖ 8.11 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · 10.1 AIC · ⌖ 5.64 AIC · ⊞ 4.7K · ◷
_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · 7.79 AIC · ⌖ 6.55 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · 8.05 AIC · ⌖ 8.96 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · 9.66 AIC · ⌖ 5.93 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

pr-sous-chef run: https://github.com/github/gh-aw/actions/runs/28907709886

Generated by 👨‍🍳 PR Sous Chef · 13 AIC · ⌖ 12.3 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-07-07T13:19:09Z

🤖 PR Triage · Run §28868091227

Field	Value
Category	feature
Risk	Medium
Score	38 / 100
Action	defer

Score breakdown: Impact 15 · Urgency 10 · Quality 13

Rationale: Draft. Adds memory-store hydration to pre_activation / on.steps. Related to #43984 (cache/repo-memory ordering) — defer until #43984 is reviewed/merged first to avoid rework.

Labels: pr-type:feature pr-risk:medium pr-priority:low pr-action:defer

Generated by 🔧 PR Triage Agent · 119.4 AIC · ⌖ 6.65 AIC · ⊞ 5.4K · ◷

Copilot

Pull request overview

This PR updates the workflow compiler so that workflows using on.steps can access previously persisted memory state during the pre_activation job, enabling deterministic dispatch gating without needing an LLM turn to reconstruct state.

Changes:

Adds pre-activation memory hydration via a new buildPreActivationMemoryRestoreSteps hook that runs before injectPreActivationOnSteps.
Extends on_steps tests to validate memory restore steps are present and ordered before the on.steps gate, and that explicit write-back steps are absent.
Updates a generated workflow lock file to reflect the new pre-activation repo-memory clone step.

Show a summary per file

File	Description
pkg/workflow/compiler_pre_activation_job.go	Adds pre-activation memory restore step generation before `on.steps` injection.
pkg/workflow/on_steps_test.go	Adds coverage asserting memory restore steps appear in `pre_activation` before the `on.steps` gate.
.github/workflows/daily-cli-performance.lock.yml	Regenerates lock output to include the new pre-activation repo-memory restore step.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 3/3 changed files
Comments generated: 2
Review effort level: Low

+	var memorySteps strings.Builder
+
+	generateCacheMemorySteps(&memorySteps, data)
+	generateRepoMemorySteps(&memorySteps, data)


+		// Memory stores should be restored before on.steps run in pre-activation.
+		assert.Contains(t, preActivationSection, "Restore cache-memory file share data")
+		assert.Contains(t, preActivationSection, "Clone repo-memory branch (default)")
+		assert.Contains(t, preActivationSection, "Prepare comment memory files")
+		assert.Contains(t, preActivationSection, "        id: gate")


github-actions · 2026-07-07T14:45:55Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

github-actions · 2026-07-07T14:45:58Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

github-actions · 2026-07-07T14:45:58Z

⚠️ PR Code Quality Reviewer failed during code quality review.

github-actions · 2026-07-07T14:45:59Z

✅ Test Quality Sentinel completed test quality analysis.

…pre-activation

github-actions · 2026-07-07T14:53:17Z

🏗️ Design Decision Gate — ADR Required

This PR makes significant changes to core business logic (111 new lines in pkg/) but does not have a linked Architecture Decision Record (ADR).

📄 Draft ADR committed: docs/adr/44015-expose-memory-stores-to-on-steps-pre-activation.md — review and complete it before merging.

🔒 This PR cannot merge until an ADR is linked in the PR body.

📋 What to do next

Review the draft ADR committed to your branch — it was generated from the PR diff
Complete the missing sections — add context the AI could not infer, refine the decision rationale, and list real alternatives you considered
Commit the finalized ADR to docs/adr/ on your branch
Reference the ADR in this PR body by adding a line such as:

ADR: ADR-44015: Expose Memory Stores to on.steps in Pre-Activation

Once an ADR is linked in the PR body, this gate will re-run and verify the implementation matches the decision.

❓ Why ADRs Matter

"AI made me procrastinate on key design decisions. Because refactoring was cheap, I could always say 'I'll deal with this later.' Deferring decisions corroded my ability to think clearly."

ADRs create a searchable, permanent record of why the codebase looks the way it does. Future contributors (and your future self) will thank you.

📋 Michael Nygard ADR Format Reference

An ADR must contain these four sections to be considered complete:

Context — What is the problem? What forces are at play?
Decision — What did you decide? Why?
Alternatives Considered — What else could have been done?
Consequences — What are the trade-offs (positive and negative)?

All ADRs are stored in docs/adr/ as Markdown files numbered by PR number (e.g., 44015-expose-memory-stores-to-on-steps-pre-activation.md for PR #44015).

🏗️ ADR gate enforced by Design Decision Gate 🏗️ · 36.3 AIC · ⌖ 12.8 AIC · ⊞ 8.5K · ◷
_{Comment /review to run again}

github-actions · 2026-07-07T14:53:49Z

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🧪 Test quality analysis by Test Quality Sentinel · 35.9 AIC · ⌖ 9.98 AIC · ⊞ 6.8K · ◷
_{Comment /review to run again}

github-actions

Test Quality Sentinel: 90/100. 0% implementation tests (threshold: 30%). One new design_test with behavioral_contract coverage; minor: 4 assert calls lack failure-context messages; inflation ratio 2.47:1 (expected for compiler integration tests). No guideline violations.

Copilot · 2026-07-07T23:41:28Z

@copilot please run the pr-finisher skill, make this PR merge-ready, address all unresolved review feedback, and rerun checks once the branch is up to date.

...

Ran pr-finisher on head b8514e4. No additional code changes were needed; unresolved feedback remains covered by 315c559, d6faece, and 85aabb5.

Re-ran local checks successfully: make fmt, make lint, make test-unit, make test, make recompile, and make agent-report-progress.

Current PR workflow runs on this head are action_required with no jobs started, so CI on this head is still unverified until a maintainer re-triggers workflows.

gh-aw-bot · 2026-07-08T00:19:15Z

\n@copilot please run the skill, make this PR merge-ready, address all unresolved review feedback, and rerun checks once the branch is up to date.\n\nOutstanding review feedback to address first:\n- github-actions: outstanding requested changes on this PR\n- github-actions: outstanding requested changes on this PR

Generated by 👨‍🍳 PR Sous Chef · 13 AIC · ⌖ 12.3 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

pelikhan · 2026-07-08T01:41:08Z

@copilot

merge main and recompile
add frontmatter field

on.restore-memory: true/false

to enable this behavior. False by default.

gh-aw-bot · 2026-07-08T01:52:05Z

@copilot please run the pr-finisher skill, make this PR merge-ready, address unresolved review feedback, and rerun checks once the branch is up to date.

Generated by 👨‍🍳 PR Sous Chef · 9.99 AIC · ⌖ 9.17 AIC · ⊞ 4.7K · ◷
_{Comment /souschef to run again}

…-stores-on-steps Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-07-08T02:04:49Z

@copilot

merge main and recompile...

Done in 6167377.

Merged latest main into this branch.
Added on.restore-memory (boolean) to frontmatter parsing/schema.
Pre-activation memory restore now runs only when on.restore-memory: true (default is false).
Recompiled workflows and updated generated lock output accordingly.
Validation passed locally: make fmt, make lint, make test-unit, make test, make recompile, make agent-report-progress.

Done

Copilot · 2026-07-08T02:19:08Z

@copilot please run the pr-finisher skill, make this PR merge-ready, address unresolved review feedback, and rerun checks once the branch is up to date.

...

Ran pr-finisher triage on current head 6167377 and revalidated locally: make fmt, make lint, make test-unit, make test, make recompile, and make agent-report-progress all pass.

No further code changes were needed in this pass; unresolved review feedback is already addressed by 6167377 (with earlier supporting fixes in 85aabb5, d6faece, and 315c559).

Current PR workflow runs on this head are action_required/stale (agent pushes do not trigger CI), so required checks need a maintainer-triggered rerun.

pelikhan · 2026-07-08T02:19:53Z

@copilot enable flag in a few agentic workflows that use memory in this repository

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-07-08T02:45:26Z

@copilot enable flag in a few agentic workflows that use memory in this repository

Implemented in caac628.

Enabled on.restore-memory: true in these memory-using workflows:

.github/workflows/daily-cli-performance.md
.github/workflows/smoke-copilot.md
.github/workflows/smoke-codex.md

Also fixed compilation/schema handling by commenting out on.restore-memory in generated YAML (same path used for on.steps/on.permissions) and added regression coverage in pkg/workflow/on_steps_test.go.

Recompiled workflows and re-ran checks (make recompile, go test ./pkg/workflow -run TestOnSteps, make agent-report-progress).

github-actions · 2026-07-08T05:42:57Z

🎉 This pull request is included in a new release.

Release: v0.82.4

Initial plan

1812bc3

Copilot AI assigned Copilot and pelikhan Jul 7, 2026

Copilot AI linked an issue Jul 7, 2026 that may be closed by this pull request

[plan] Expose memory stores to on.steps pre-activation filter for deterministic dispatch decisions #43945

Closed

7 tasks

Copilot started work on behalf of pelikhan July 7, 2026 12:14 View session

Restore memory stores before on.steps in pre-activation

ee0df32

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Expose memory stores to on.steps pre-activation filter~~ Expose memory stores to on.steps in pre-activation for deterministic dispatch gating Jul 7, 2026

Copilot finished work on behalf of pelikhan July 7, 2026 12:44

Copilot AI requested a review from pelikhan July 7, 2026 12:44

github-actions Bot added pr-action:defer pr-agent:copilot pr-priority:low pr-risk:medium pr-type:feature labels Jul 7, 2026

This was referenced Jul 7, 2026

Move cache-memory and repo-memory restore steps before user steps: in agent job #43984

Merged

[PR Triage Report] PR Triage Report — 2026-07-07 (Run §28868091227) #44028

Closed

[Contribution Check Report] Contribution Check — 2026-07-07 #43904

Closed

pelikhan marked this pull request as ready for review July 7, 2026 14:26

Copilot AI review requested due to automatic review settings July 7, 2026 14:26

Copilot started reviewing on behalf of pelikhan July 7, 2026 14:27 View session

Copilot AI reviewed Jul 7, 2026

View reviewed changes

docs(adr): add draft ADR-44015 for memory store exposure to on.steps …

ab61304

…pre-activation

github-actions Bot approved these changes Jul 7, 2026

View reviewed changes

github-actions Bot mentioned this pull request Jul 7, 2026

[pr-sous-chef] Run report — 8 nudged, 2 skipped #44130

Closed

Copilot started work on behalf of gh-aw-bot July 7, 2026 23:29 View session

Copilot finished work on behalf of gh-aw-bot July 7, 2026 23:42

github-actions Bot mentioned this pull request Jul 7, 2026

[pr-sous-chef] Run report — 0 nudged, 10 processed #44132

Closed

github-actions Bot mentioned this pull request Jul 8, 2026

[pr-sous-chef] Run report — 8 nudged, 2 skipped #44136

Closed

github-actions Bot added the pr-priority:medium label Jul 8, 2026

github-actions Bot mentioned this pull request Jul 8, 2026

[PR Triage Report] 🤖 PR Triage Report — 2026-07-08 (Run §28909358158) #44147

Closed

6 tasks

Copilot started work on behalf of pelikhan July 8, 2026 01:41 View session

Merge remote-tracking branch 'origin/main' into copilot/expose-memory…

efd5ccc

…-stores-on-steps Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions Bot mentioned this pull request Jul 8, 2026

[pr-sous-chef] Run report — 7 nudged, 1 skipped #44150

Closed

Add on.restore-memory toggle for pre_activation memory hydration

6167377

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan July 8, 2026 02:05

Copilot started work on behalf of gh-aw-bot July 8, 2026 02:06 View session

Copilot finished work on behalf of gh-aw-bot July 8, 2026 02:19

Copilot started work on behalf of pelikhan July 8, 2026 02:20 View session

Enable on.restore-memory in selected memory workflows

caac628

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan July 8, 2026 02:46

pelikhan merged commit 0186054 into main Jul 8, 2026
29 checks passed

pelikhan deleted the copilot/expose-memory-stores-on-steps branch July 8, 2026 02:57

github-actions Bot mentioned this pull request Jul 8, 2026

[PR Triage Report] [PR Triage] 2026-07-08 — 11 open Copilot PRs — Run §28924016278 #44236

Closed

Uh oh!

Conversation

Copilot AI commented Jul 7, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 7, 2026

🤖 PR Triage · Run §28868091227

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 7, 2026

🏗️ Design Decision Gate — ADR Required

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jul 7, 2026

Uh oh!

gh-aw-bot commented Jul 8, 2026

Uh oh!

pelikhan commented Jul 8, 2026

Uh oh!

gh-aw-bot commented Jul 8, 2026

Uh oh!

Copilot AI commented Jul 8, 2026

Uh oh!

Copilot AI commented Jul 8, 2026

Uh oh!

pelikhan commented Jul 8, 2026

Uh oh!

Copilot AI commented Jul 8, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jul 7, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Jul 7, 2026 •

edited

Loading

github-actions Bot commented Jul 7, 2026 •

edited

Loading

github-actions Bot commented Jul 7, 2026 •

edited

Loading

github-actions Bot commented Jul 7, 2026 •

edited

Loading