Skip to content

Sync designer.md with network shorthand corrections and skills/lsp/evals fields - #50175

Merged
pelikhan merged 2 commits into
mainfrom
copilot/fix-network-shorthand-corrections
Aug 4, 2026
Merged

Sync designer.md with network shorthand corrections and skills/lsp/evals fields#50175
pelikhan merged 2 commits into
mainfrom
copilot/fix-network-shorthand-corrections

Conversation

Copilot AI commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

The Designer Drift Audit found .github/aw/designer.md out of sync with its reference docs: the network mapping table omitted the invalid-shorthand corrections from network.md, and the generation template had no coverage of the skills:, lsp:, and evals: frontmatter fields.

Changes

  • Network shorthands — added an "Invalid Network Shorthands" table under Network Mapping mirroring network.md, so the designer corrects compile-breaking values rather than emitting them: npmnode, pypi/pippython, cargorust, gem/gemsruby, nugetdotnet, maven/gradlejava, composerphp, dockercontainers, localhostlocal.

  • New frontmatter fields — generation template now includes skills:, lsp:, and evals: with inline constraints:

    skills:
      - <owner/repo/skill@sha or .github/skills/<name> — only if domain knowledge is needed>
    lsp:
      <language-key>:                 # optional, engine: copilot only (experimental)
        command: <server-executable>
        fileExtensions:
          ".<ext>": <language-id>
    evals:
      - id: <eval-id>                 # optional, requires safe-outputs
        question: <binary YES/NO question about the agent output>
  • Elicitation — new "Phase 7b: Skills, LSP & Evals" so these are asked about only when relevant.

  • Validation checklist — added checks for valid ecosystem identifiers, pinned skill refs, lsp restricted to engine: copilot, and evals requiring safe-outputs (for agent_output.json).

  • References — added skills.md, lsp.md, evals.md to both the in-repo and portable HTTPS reference lists.

Not addressed

.github/agents/interactive-agent-designer.agent.md is in the agent-instructions directory, which is outside what I can read or edit, so the same sync has not been applied there and likely still needs a follow-up.

…fields

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix designer drift by updating network shorthand corrections Sync designer.md with network shorthand corrections and skills/lsp/evals fields Aug 4, 2026
Copilot AI requested a review from pelikhan August 4, 2026 05:07
@pelikhan
pelikhan marked this pull request as ready for review August 4, 2026 05:07
Copilot AI balanced review requested due to automatic review settings August 4, 2026 05:07
@pelikhan
pelikhan merged commit cd85bff into main Aug 4, 2026
@pelikhan
pelikhan deleted the copilot/fix-network-shorthand-corrections branch August 4, 2026 05:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the workflow designer to cover network shorthand corrections and newer frontmatter fields.

Changes:

  • Adds invalid network shorthand mappings.
  • Adds guidance and templates for skills, LSP, and evals.
  • Extends validation and reference lists.
Show a summary per file
File Description
.github/aw/designer.md Synchronizes designer guidance with reference documentation.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Suppressed comments (1)

.github/aw/designer.md:366

  • The generated placeholder still suggests an unspecified @sha and omits the supported skills/<name> local path. Because this is the skeleton copied into output, an abbreviated SHA can produce a compile-time validation error; show the full 40-character lowercase requirement and both documented local roots.
  - <owner/repo/skill@sha or .github/skills/<name> — only if domain knowledge is needed>
  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment thread .github/aw/designer.md

Map to:
- `skills:` — pinned external skills (`owner/repo/skill@sha`) or local paths (`.github/skills/<name>`) when the agent needs domain knowledge (see `.github/aw/skills.md`)
- `lsp:` — language servers for code intelligence; **experimental** and only valid with `engine: copilot` (see `.github/aw/lsp.md`)
Comment thread .github/aw/designer.md
Ask only when relevant: **"Does the agent need extra domain knowledge, language-server code intelligence, or automated success checks?"**

Map to:
- `skills:` — pinned external skills (`owner/repo/skill@sha`) or local paths (`.github/skills/<name>`) when the agent needs domain knowledge (see `.github/aw/skills.md`)
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.84.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Designer Drift AuditDesigner files out of sync: network shorthand corrections and skills/lsp/evals fields missing

3 participants