Sync designer.md with network shorthand corrections and skills/lsp/evals fields - #50175
Merged
Conversation
…fields Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix designer drift by updating network shorthand corrections
Sync designer.md with network shorthand corrections and skills/lsp/evals fields
Aug 4, 2026
pelikhan
approved these changes
Aug 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the workflow designer to cover network shorthand corrections and newer frontmatter fields.
Changes:
- Adds invalid network shorthand mappings.
- Adds guidance and templates for skills, LSP, and evals.
- Extends validation and reference lists.
Show a summary per file
| File | Description |
|---|---|
.github/aw/designer.md |
Synchronizes designer guidance with reference documentation. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Suppressed comments (1)
.github/aw/designer.md:366
- The generated placeholder still suggests an unspecified
@shaand omits the supportedskills/<name>local path. Because this is the skeleton copied into output, an abbreviated SHA can produce a compile-time validation error; show the full 40-character lowercase requirement and both documented local roots.
- <owner/repo/skill@sha or .github/skills/<name> — only if domain knowledge is needed>
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Balanced
|
|
||
| Map to: | ||
| - `skills:` — pinned external skills (`owner/repo/skill@sha`) or local paths (`.github/skills/<name>`) when the agent needs domain knowledge (see `.github/aw/skills.md`) | ||
| - `lsp:` — language servers for code intelligence; **experimental** and only valid with `engine: copilot` (see `.github/aw/lsp.md`) |
| Ask only when relevant: **"Does the agent need extra domain knowledge, language-server code intelligence, or automated success checks?"** | ||
|
|
||
| Map to: | ||
| - `skills:` — pinned external skills (`owner/repo/skill@sha`) or local paths (`.github/skills/<name>`) when the agent needs domain knowledge (see `.github/aw/skills.md`) |
This was referenced Aug 4, 2026
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Designer Drift Audit found
.github/aw/designer.mdout of sync with its reference docs: the network mapping table omitted the invalid-shorthand corrections fromnetwork.md, and the generation template had no coverage of theskills:,lsp:, andevals:frontmatter fields.Changes
Network shorthands — added an "Invalid Network Shorthands" table under Network Mapping mirroring
network.md, so the designer corrects compile-breaking values rather than emitting them:npm→node,pypi/pip→python,cargo→rust,gem/gems→ruby,nuget→dotnet,maven/gradle→java,composer→php,docker→containers,localhost→local.New frontmatter fields — generation template now includes
skills:,lsp:, andevals:with inline constraints:Elicitation — new "Phase 7b: Skills, LSP & Evals" so these are asked about only when relevant.
Validation checklist — added checks for valid ecosystem identifiers, pinned skill refs,
lsprestricted toengine: copilot, and evals requiringsafe-outputs(foragent_output.json).References — added
skills.md,lsp.md,evals.mdto both the in-repo and portable HTTPS reference lists.Not addressed
.github/agents/interactive-agent-designer.agent.mdis in the agent-instructions directory, which is outside what I can read or edit, so the same sync has not been applied there and likely still needs a follow-up.