[WIP] Fix goose agentic engine configuration #50186
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -144,13 +144,24 @@ func (e *BehaviorDefinedEngine) GetSecretValidationStep(workflowData *WorkflowDa | |
|
|
||
| func (e *BehaviorDefinedEngine) GetInstallationSteps(workflowData *WorkflowData) []GitHubActionStep { | ||
| behavior := e.behavior() | ||
| if behavior == nil { | ||
| return nil | ||
| } | ||
| if workflowData != nil && workflowData.EngineConfig != nil && workflowData.EngineConfig.Command != "" { | ||
| return nil | ||
| } | ||
|
|
||
| // Behavior-defined engines that execute via a harness script (e.g. Goose) run the | ||
| // harness through Node.js, so Node.js (and, when the firewall is enabled, the AWF | ||
| // binary) must always be installed even when no package-manager based installation | ||
| // is declared for the engine's CLI itself. | ||
| if behavior.Installation == nil { | ||
| if behavior.HarnessScript == "" { | ||
| return nil | ||
| } | ||
| return BuildNpmEngineInstallStepsWithAWF([]GitHubActionStep{GenerateNodeJsSetupStep()}, workflowData) | ||
|
Comment on lines
+158
to
+162
Contributor
There was a problem hiding this comment. [/tdd] The new harness-script installation path lacks a regression test — without one, a future refactor could silently break Goose (and similar harness-only engines) again. 💡 Suggested test skeletonAdd two tests in
The @copilot please address this. |
||
| } | ||
|
|
||
| install := behavior.Installation | ||
| if install.PackageManager != "npm" { | ||
| return nil | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing test coverage for the new
Installation == nil && HarnessScript != ""branch, and the generatedsmoke-goose.lock.ymlwasn't recompiled/committed in this PR (per the PR's own checklist) — the fix is unverified end-to-end.💡 Why this matters
This branch changes behavior for every harness-script engine without an explicit
installation:block (Goose today, potentially others later). Without a unit test assertingGetInstallationStepsreturns Node.js (+ AWF when firewall enabled) for such a config, a future refactor could silently regress this exact bug. Also, sincemake recompilewasn't run, the actual generated.lock.ymlfor smoke-goose still lacks the fix — so the described root cause is not actually resolved in this PR's committed artifacts, only in source.Suggested fix: add a test in
behavior_defined_engine_harness_test.gosimilar tonewHarnessEngineDefinition()but withInstallation: nil, assertingGetInstallationStepsreturns Node.js setup (+AWF when firewall enabled), and run/commitmake recompileoutput forsmoke-goose.lock.yml.