Document boolean duplicate-constant threshold - #50261
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
Hey Why this matters: Booleans have only 2 possible values, making coincidental duplication far more likely than the numeric case. The fix mirrors the existing What's been done:
Ready to go: This PR is authored by the Copilot coding agent and follows the intended agentic workflow process. The underlying work is complete and well-tested. Once the changeset is finalized (currently in WIP state), this should be ready for merge.
|
There was a problem hiding this comment.
Pull request overview
Documents the duplicate-reporting threshold for numeric and boolean constants.
Changes:
- Clarifies that three matching module-level constants are required before reporting numeric or boolean duplicates.
Show a summary per file
| File | Description |
|---|---|
eslint-factory/README.md |
Documents numeric and boolean duplicate thresholds. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
|
🎉 This pull request is included in a new release. Release: |
no-duplicate-constant-valuesapplies a three-declaration coincidence guard to booleans, matching numeric constants. This avoids reporting common module-level flag values as duplicates.Rule behavior
Documentation