Consolidate CLI validation issue types

[Copilot]

ErrorInfo and CompileValidationError modeled the same validation issue shape separately in pkg/cli, with only audit reports carrying an optional file field. This PR consolidates them while preserving existing JSON field names.

• Shared type
  • Adds ValidationIssue with common type, message, line, and optional file fields.
  • Updates audit-report and compile-validation results to use the shared type.

type ValidationIssue struct {
    Type    string `json:"type"`
    Message string `json:"message"`
    Line    int    `json:"line,omitempty"`
    File    string `json:"file,omitempty"`
}

• Call-site cleanup

  • Replaces ErrorInfo and CompileValidationError usages across audit extraction/rendering, findings generation, compile validation, MCP validation injection, and tests.

• Compatibility coverage

  • Adds focused JSON serialization coverage for compile validation and audit-report issue payloads.
  • Keeps file omitted for compile issues unless set.

• Fixes [Code Quality] Consolidate ErrorInfo and CompileValidationError into shared ValidationIssue type #51078

---

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 9.99 AIC · ⊞ 8.4K · ◷
_{Comment /souschef to run again}

[Copilot]

Pull request overview

Consolidates duplicate CLI validation models into the shared ValidationIssue type while preserving JSON fields.

Changes:

• Replaces ErrorInfo and CompileValidationError.
• Updates compile, audit, MCP, rendering, and analysis paths.
• Adds JSON compatibility tests and documentation.

Show a summary per file

File	Description
pkg/cli/validation_issue.go	Defines the shared type.
pkg/cli/validation_issue_test.go	Tests JSON compatibility.
pkg/cli/README.md	Updates exported-type documentation.
pkg/cli/mcp_tools_readonly.go	Migrates MCP validation warnings.
pkg/cli/compile_workflow_processor.go	Migrates workflow validation issues.
pkg/cli/compile_validation.go	Migrates validation sanitization.
pkg/cli/compile_repository_manifest.go	Migrates manifest issues.
pkg/cli/compile_pipeline.go	Migrates pipeline issues.
pkg/cli/compile_config.go	Updates validation result fields.
pkg/cli/compile_command_test.go	Updates compile tests.
pkg/cli/audit_test.go	Updates audit tests.
pkg/cli/audit_report.go	Migrates audit issue handling.
pkg/cli/audit_report_test.go	Updates audit-report tests.
pkg/cli/audit_report_render.go	Migrates console rendering.
pkg/cli/audit_report_analysis.go	Migrates audit analysis.
pkg/cli/audit_agent_output_test.go	Updates findings tests.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 16/16 changed files
• Comments generated: 1
• Review effort level: Balanced

[gh-aw-bot]

@copilot Please address the remaining review feedback, refresh the branch if GitHub can update it cleanly, and run the pr-finisher skill before handing back to maintainers.

Open items to address (newest first):

• copilot-pull-request-reviewer: Consolidate CLI validation issue types #51098 (review)

Branch refresh was requested.

Run context: https://github.com/github/gh-aw/actions/runs/31197566542

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 9.99 AIC · ⊞ 8.4K · ◷
_{Comment /souschef to run again}

[Copilot]

@copilot Please address the remaining review feedback, refresh the branch if GitHub can update it cleanly, and run the pr-finisher skill before handing back to maintainers.

Open items to address (n...

Fixed in the latest commit. sanitizeValidationResults now copies e.File into the reconstructed ValidationIssue, so the file field is preserved through the sanitization boundary.

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.86.1