Improve test quality: migrate tracker_id_integration_test.go to testify assertions by Copilot · Pull Request #51178 · github/gh-aw

Copilot · 2026-08-07T19:58:10Z

pkg/workflow/tracker_id_integration_test.go relied entirely on raw t.Fatalf/t.Errorf, lacked coverage for invalid tracker-id values despite documented validation constraints (min 8 chars, alphanumeric + hyphens/underscores), and used manual os.Remove cleanup that could be skipped on early test failures.

Testify migration: replaced t.Fatalf/t.Errorf with require.NoError/require.Error for compile-step assertions and assert.Contains/assert.NotContains for content checks, so a subtest can surface multiple independent failures instead of stopping at the first one.
New test cases: added subtests for too-short tracker-id, tracker-id with spaces, tracker-id with invalid characters (all expected to fail compilation), and a tracker-id combined with multiple safe-outputs (create-issue + create-pull-request) in the same workflow.
Cleanup hardening: each subtest now creates its own tmpDir via testutil.TempDir, which registers t.Cleanup internally, removing the need for manual os.Remove calls at the end of the subtest and ensuring cleanup runs on early failures or panics. This also removes the shared-filename risk across subtests, making them safe for future t.Parallel().
Shared helper: extracted assertScriptUsesRequire(t, contentStr) for the repeated "env var set + script loaded via require()" assertion pattern, intended to be reusable across sibling *_integration_test.go files.

Fixes [testify-expert] Improve Test Quality: pkg/workflow/tracker_id_integration_test.go #51152

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 12.1 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

…again

Copilot

Pull request overview

Improves tracker ID integration tests with Testify, broader validation coverage, and safer temporary-file cleanup.

Changes:

Migrates assertions to Testify.
Adds invalid and multi-output tracker ID cases.
Uses per-subtest temporary directories and extracts a shared assertion helper.

Show a summary per file

File	Description
`pkg/workflow/tracker_id_integration_test.go`	Expands and refactors tracker ID integration tests.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 2
Review effort level: Balanced

+// mode, not inline).
+func assertScriptUsesRequire(t *testing.T, contentStr string) {
+	t.Helper()
+	assert.Contains(t, contentStr, "GH_AW_TRACKER_ID", "expected GH_AW_TRACKER_ID environment variable to be set")


+			if tt.shouldCompile {
+				require.NoError(t, err, "expected compilation to succeed")
+			} else {
+				require.Error(t, err, "expected compilation to fail")


pelikhan · 2026-08-07T20:37:14Z

@copilot lint go

pelikhan · 2026-08-07T21:00:07Z

@copilot fix https://github.com/github/gh-aw/actions/runs/31215110611/job/92987222216?pr=51178

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-08-07T21:10:34Z

@copilot fix https://github.com/github/gh-aw/actions/runs/31215110611/job/92987222216?pr=51178

Fixed in 77a723c. The referenced custom lint checks now pass.

github-actions · 2026-08-07T21:12:53Z

🎯 Excellent work on the test quality improvements! This PR tackles exactly what the testify-expert review flagged in #51152 — migrating the tracker_id_integration_test.go file from raw t.Fatalf/t.Errorf to structured testify assertions, plus adding crucial edge-case coverage for invalid tracker-id values.

What stands out:

✅ Comprehensive testify migration with proper use of require.NoError/require.Error for fatal assertions and assert.Contains/assert.NotContains for flexible checks
✅ New subtests for validation boundaries (too-short, spaces, invalid characters)
✅ Smart cleanup hardening via t.Cleanup registered per-subtest, removing the manual os.Remove risk
✅ Extracted assertScriptUsesRequire helper for reusable patterns across sibling integration tests
✅ Well-documented PR body with clear rationale for each change

This PR is ready for review and merge. The changes directly improve maintainability and test signal quality, and align perfectly with the project's test-driven agentic workflow.

Generated by ✅ Contribution Check · auto · 78.4 AIC · ⊞ 8.7K · ◷

…again

gh-aw-bot · 2026-08-07T21:14:23Z

@copilot Quick triage nudge for this PR.

Please refresh the branch, address any remaining review feedback, run the pr-finisher skill, and push follow-up fixes.

no recorded failed checks in compact candidate data

Run: https://github.com/github/gh-aw/actions/runs/31218745745

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 12.1 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

…fy assertions (#51178) * Initial plan * Improve test quality: migrate tracker_id_integration_test.go to testify Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Fix engine definition custom lint findings Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Use consistent engine import empty checks Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

github-actions · 2026-08-07T21:52:15Z

🎉 This pull request is included in a new release.

Release: v0.86.1

Initial plan

d517a98

Copilot AI assigned Copilot and pelikhan Aug 7, 2026

Copilot started work on behalf of pelikhan August 7, 2026 19:58 View session

Copilot AI linked an issue Aug 7, 2026 that may be closed by this pull request

[testify-expert] Improve Test Quality: pkg/workflow/tracker_id_integration_test.go #51152

Closed

6 tasks

Improve test quality: migrate tracker_id_integration_test.go to testify

2162b45

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Improve test quality for integration test in tracker_id~~ Improve test quality: migrate tracker_id_integration_test.go to testify assertions Aug 7, 2026

Copilot finished work on behalf of pelikhan August 7, 2026 20:11

Copilot AI requested a review from pelikhan August 7, 2026 20:11

pelikhan marked this pull request as ready for review August 7, 2026 20:15

Copilot AI balanced review requested due to automatic review settings August 7, 2026 20:15

Copilot started reviewing on behalf of pelikhan August 7, 2026 20:15 View session

Merge branch 'main' into copilot/testify-expert-improve-test-quality-…

df40f50

…again

Copilot AI reviewed Aug 7, 2026

View reviewed changes

Copilot started work on behalf of pelikhan August 7, 2026 20:37 View session

Copilot finished work on behalf of pelikhan August 7, 2026 20:45

github-actions Bot mentioned this pull request Aug 7, 2026

[pr-sous-chef] PR Sous Chef run report #50950

Closed

Copilot started work on behalf of pelikhan August 7, 2026 21:00 View session

Copilot AI and others added 2 commits August 7, 2026 21:08

Fix engine definition custom lint findings

d77f109

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Use consistent engine import empty checks

77a723c

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan August 7, 2026 21:11

github-actions Bot mentioned this pull request Aug 7, 2026

[Contribution Check Report] Contribution Check — 2026-08-07 #50967

Closed

Merge branch 'main' into copilot/testify-expert-improve-test-quality-…

c79cfd1

…again

Copilot started work on behalf of gh-aw-bot August 7, 2026 21:16 View session

pelikhan merged commit 475927d into main Aug 7, 2026
1 of 3 checks passed

pelikhan deleted the copilot/testify-expert-improve-test-quality-again branch August 7, 2026 21:20

Copilot stopped work on behalf of gh-aw-bot due to an error August 7, 2026 21:20
The session was cancelled by the user.

Copilot AI requested a review from gh-aw-bot August 7, 2026 21:20

github-actions Bot mentioned this pull request Aug 7, 2026

Smoke Test: MAI-Code-1-Flash - 31220061988 #51200

Closed

This was referenced Aug 7, 2026

Smoke Test: MAI-Code-1-Flash - 31222506585 #51219

Closed

Smoke Test: MAI-Code-1-Flash - 31231539109 #51260

Closed

Navigation Menu

Uh oh!

Improve test quality: migrate tracker_id_integration_test.go to testify assertions - #51178

Improve test quality: migrate tracker_id_integration_test.go to testify assertions#51178
pelikhan merged 6 commits into
mainfrom
copilot/testify-expert-improve-test-quality-again

Copilot AI commented Aug 7, 2026 •

edited by github-actions Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

pelikhan commented Aug 7, 2026

Uh oh!

pelikhan commented Aug 7, 2026

Uh oh!

Copilot AI commented Aug 7, 2026

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

gh-aw-bot commented Aug 7, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Copilot AI commented Aug 7, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

pelikhan commented Aug 7, 2026

Uh oh!

pelikhan commented Aug 7, 2026

Uh oh!

Copilot AI commented Aug 7, 2026

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

gh-aw-bot commented Aug 7, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Aug 7, 2026 •

edited by github-actions Bot

Loading