Extract Design Decision Gate ADR report templates into an on-demand inline skill - #51182
Merged
Conversation
8 tasks
…ne skill Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Optimize daily ambient context data collection
Extract Design Decision Gate ADR report templates into an on-demand inline skill
Aug 7, 2026
pelikhan
marked this pull request as ready for review
August 7, 2026 20:33
Contributor
There was a problem hiding this comment.
Pull request overview
Extracts ADR report templates into an inline skill to reduce the Design Decision Gate’s initial prompt size.
Changes:
- Moves three ADR comment templates into an on-demand skill.
- Regenerates workflow metadata.
- However, one combined skill still loads all templates per invocation.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/design-decision-gate.md |
Extracts and references ADR templates. |
.github/workflows/design-decision-gate.lock.yml |
Updates the generated body hash. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
+390
to
+392
| ## skill: `adr-report-templates` | ||
| --- | ||
| description: PR comment templates for the Design Decision Gate (ADR Required, ADR Verified, and Implementation Diverges). |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Daily Ambient Context Optimizer flagged Design Decision Gate as the largest sampled first request (33,055 chars — nearly double the other sampled workflows), driven by three large
<details>-heavy report templates inlined in the prompt body even though at most one is used per run.Changes
.github/workflows/design-decision-gate.md## skill: adr-report-templatesblock at the end of the file..github/workflows/design-decision-gate.lock.yml— regenerated; single-linegh-aw-metadatabody_hashupdate, no other lock files affected.Inline skills are extracted at setup time by
actions/setup/js/extract_inline_skills.cjsand stripped from the main prompt, so the templates are read on demand rather than shipped on every run. Mirrors the existing## skill: test-report-templatespattern intest-quality-sentinel.md.Before:
After:
Prompt body drops 14,717 → 11,467 chars (−22%), verified against the repo's own extractor. Template content is unchanged — this is pure relocation.
Scoped out
Recommendations 2–4 from the issue (shared "What to do next" fragment, extracting the generic efficiency-rules preamble, trimming the
grumpy-coder/pr-triageagent blocks) are marked needs manual review and span two additional workflows' review semantics. Left for a follow-up so this stays a single verifiable change.Note for reviewers
The issue's checklist requires "Do not submit as a draft PR," which conflicts with the standing preference to open PRs in draft. I followed the issue here — say the word if the draft convention should take precedence.