Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
👋 Thanks for working on this!The PR implements the Docker Sandbox runtime default feature for GitHub-hosted Ubuntu runners as planned in #51252. The description clearly outlines the behavior (default selection, fallback handling, and explicit overrides), and the regenerated workflow lock files are consistent with the approach. Here are a few areas to strengthen before this is ready for merge: Add test coverage — The new runtime selection logic (preferring
This ensures the logic is resilient and maintainable as the codebase evolves. Verify test files — The large diff is mostly auto-generated workflow lock files (expected), but confirm that tests for the underlying runtime selection code are present. If the logic is in Go code, look for corresponding Note on draft status — The PR is currently in draft mode. When you're ready for review, remember to mark it ready for review so maintainers can prioritize it. If you'd like help adding tests for the runtime selection logic, you can assign this prompt to your coding agent:
|
GitHub-hosted Ubuntu workflows now prefer Docker Sandbox (
docker sbx) when no agent runtime is explicitly configured. Explicit runtime selection and self-hosted/local defaults remain unchanged.Default runtime selection
docker-sbxfor supported GitHub-hosted Ubuntu labels.sandbox.agent.runtimeoverrides.Runtime fallback
Generated workflows and documentation