Document missing internal dependencies in parser, cli, and workflow specs - #51380
Merged
Conversation
6 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Resolve dependency mismatches in package specifications
Document missing internal dependencies in parser, cli, and workflow specs
Aug 8, 2026
pelikhan
marked this pull request as ready for review
August 8, 2026 15:00
Contributor
There was a problem hiding this comment.
Pull request overview
Updates package specifications to resolve dependency-documentation gaps identified in issue #51379.
Changes:
- Documents
syncutilin the parser specification. - Documents
colorwriter,ctxutil, andgithubapiin the CLI specification. - Documents
ctxutilin the workflow specification.
Show a summary per file
| File | Description |
|---|---|
pkg/parser/README.md |
Adds the parser’s syncutil dependency. |
pkg/cli/README.md |
Adds three missing CLI internal dependencies. |
pkg/workflow/README.md |
Adds the workflow package’s ctxutil dependency. |
Review details
Tip
Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec-librarian audit found three package specs whose
## Dependenciessections had drifted from the actual non-test imports. This is a documentation-only change.Changes
pkg/parser/README.md— addedsyncutil(OnceLoaderfor lazy schema compilation inschema_compiler.go)pkg/cli/README.md— addedcolorwriter(Degradeincompile_schedule_calendar.go),ctxutil, andgithubapi(ClientOptionsinupdate_check.go)pkg/workflow/README.md— addedctxutil(OrBackgroundinauto_update_workflow.go,compiler_model_pricing.go,github_cli_wasm.go)Descriptions reuse the wording already established for these packages elsewhere in the specs.
Notes for reviewers
The audit also flagged
stringutilas undocumented inpkg/parser/README.md, but it was already present — no change was needed there.Each addition was checked against real usage sites rather than taken from the report. Coverage was verified by diffing documented entries against actual imports:
All three packages now report zero missing entries.
Two audit action items are intentionally not addressed here: the shallow-clone/git-history item concerns the audit workflow's checkout configuration rather than package specs, and issue linking is handled separately.