Skip to content

Fix Contribution Check proxy denials and retry handling - #51631

Merged
pelikhan merged 2 commits into
mainfrom
copilot/aw-failures-fix-contribution-check-proxy
Aug 10, 2026
Merged

Fix Contribution Check proxy denials and retry handling#51631
pelikhan merged 2 commits into
mainfrom
copilot/aw-failures-fix-contribution-check-proxy

Conversation

Copilot AI commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Contribution Check was hitting AWF proxy permission denials for normal workflow work: fetching PR diffs and emitting the summary issue. The harness also treated AWF proxy blocks as non-retryable, exhausting the run after the first attempt.

  • Allow required Contribution Check shell commands

    • Adds git for PR branch fetch/diff operations.
    • Adds jq * for constructing safe-output payloads.
    • Recompiles the generated lockfile so the agent receives:
      --allow-tool 'shell(git:*)'
      --allow-tool 'shell(jq)'
      --allow-tool 'shell(safeoutputs:*)'
  • Make AWF proxy blocks retryable in Copilot harness

    • Keeps detecting AWF API-proxy block markers.
    • Removes them from the non-retryable guard path so transient proxy blocks can consume retry budget.
  • Add regression coverage

    • Verifies Contribution Check keeps the required shell permissions in source and compiled workflow output.
    • Verifies Copilot retry policy retries AWF proxy block output instead of treating it as a terminal guard condition.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix AWF proxy block in Contribution Check for permission denials Fix Contribution Check proxy denials and retry handling Aug 9, 2026
Copilot AI requested a review from pelikhan August 9, 2026 19:40
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Excellent work, Copilot! This PR comprehensively addresses the AWF proxy permission issues blocking Contribution Check workflows. The implementation is well-described and properly scoped:

The PR is well-prepared and ready for team review.

Generated by ✅ Contribution Check · auto · 90.6 AIC · ⌖ 3.4 AIC · ⊞ 8.8K ·

@github-actions

Copy link
Copy Markdown
Contributor

Triage

  • Category: bug
  • Risk: medium (touches lockfile-generating workflow + retry-guard logic)
  • Score: 62/100 (impact 25, urgency 22, quality 15)
  • Recommended action: fast_track

Draft with 1 comment, all CI checks pending/unavailable. Fixes real proxy-denial + non-retryable-block bug in Contribution Check harness that affects every subsequent AWF-proxy-blocked run. Recommend undraft + CI run before merge.

Generated by 🔧 PR Triage Agent · auto · 43.1 AIC · ⌖ 1.95 AIC · ⊞ 7.8K ·

@pelikhan
pelikhan marked this pull request as ready for review August 10, 2026 05:05
Copilot AI balanced review requested due to automatic review settings August 10, 2026 05:05
@pelikhan
pelikhan merged commit 8f8119b into main Aug 10, 2026
1 check passed
@pelikhan
pelikhan deleted the copilot/aw-failures-fix-contribution-check-proxy branch August 10, 2026 05:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Contribution Check command permissions and Copilot harness retry handling.

Changes:

  • Allows required git and jq shell commands.
  • Makes AWF proxy blocks retryable.
  • Adds workflow-contract and retry regression tests.
Show a summary per file
File Description
.github/workflows/contribution-check.md Adds shell permissions.
.github/workflows/contribution-check.lock.yml Recompiles generated permissions.
actions/setup/js/copilot_harness.cjs Removes AWF proxy blocks from one terminal guard.
actions/setup/js/copilot_harness.test.cjs Adds retry regression coverage.
pkg/cli/contribution_check_workflow_contract_test.go Verifies source and compiled permissions.

Review details

Tip

Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 5/5 changed files
  • Comments generated: 1
  • Review effort level: Balanced

});

it("retries AWF API proxy blocks instead of treating them as a guard condition", () => {
const result = { exitCode: 1, hasOutput: true, output: "awf api proxy is blocking requests for this run" };
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.86.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw-failures] [P1] Fix Contribution Check's AWF proxy block — 19 permission denials, 0 retries used

3 participants