Fix Contribution Check proxy denials and retry handling - #51631
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
Excellent work, Copilot! This PR comprehensively addresses the AWF proxy permission issues blocking Contribution Check workflows. The implementation is well-described and properly scoped:
The PR is well-prepared and ready for team review.
|
Triage
Draft with 1 comment, all CI checks pending/unavailable. Fixes real proxy-denial + non-retryable-block bug in Contribution Check harness that affects every subsequent AWF-proxy-blocked run. Recommend undraft + CI run before merge.
|
There was a problem hiding this comment.
Pull request overview
Fixes Contribution Check command permissions and Copilot harness retry handling.
Changes:
- Allows required
gitandjqshell commands. - Makes AWF proxy blocks retryable.
- Adds workflow-contract and retry regression tests.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/contribution-check.md |
Adds shell permissions. |
.github/workflows/contribution-check.lock.yml |
Recompiles generated permissions. |
actions/setup/js/copilot_harness.cjs |
Removes AWF proxy blocks from one terminal guard. |
actions/setup/js/copilot_harness.test.cjs |
Adds retry regression coverage. |
pkg/cli/contribution_check_workflow_contract_test.go |
Verifies source and compiled permissions. |
Review details
Tip
Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Balanced
| }); | ||
|
|
||
| it("retries AWF API proxy blocks instead of treating them as a guard condition", () => { | ||
| const result = { exitCode: 1, hasOutput: true, output: "awf api proxy is blocking requests for this run" }; |
|
🎉 This pull request is included in a new release. Release: |
Contribution Check was hitting AWF proxy permission denials for normal workflow work: fetching PR diffs and emitting the summary issue. The harness also treated AWF proxy blocks as non-retryable, exhausting the run after the first attempt.
Allow required Contribution Check shell commands
gitfor PR branch fetch/diff operations.jq *for constructing safe-output payloads.Make AWF proxy blocks retryable in Copilot harness
Add regression coverage