Add native-counterpart doc comments to progress_wasm.go and spinner_wasm.go - #51904
Merged
Conversation
…asm.go Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add native counterpart doc comments to progress_wasm.go and spinner_wasm.go
Add native-counterpart doc comments to progress_wasm.go and spinner_wasm.go
Aug 11, 2026
pelikhan
approved these changes
Aug 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds discoverability comments linking WASM console implementations to their native counterparts.
Changes:
- Links WASM progress and spinner implementations to native files.
- Matches the existing repository convention.
Show a summary per file
| File | Description |
|---|---|
pkg/console/progress_wasm.go |
References progress.go. |
pkg/console/spinner_wasm.go |
References spinner.go. |
Review details
Tip
Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WASM/native build-tag pattern (
//go:build js || wasmvs. native counterpart) is used across 26 files, but most pairs lack a pointer from the WASM file back to its native implementation, hurting discoverability.repository_features_validation_wasm.goalready follows this convention; two files inpkg/consolewere missing it.Changes
pkg/console/progress_wasm.go: added// For the native implementation, see progress.go.pkg/console/spinner_wasm.go: added// For the native implementation, see spinner.go.No functional change — pure discoverability improvement.