Add Kimi K3 to the Copilot model inventory - #51938
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ Test Quality Sentinel completed test quality analysis.
|
|
✅ PR Code Quality Reviewer completed the code quality review. Warning Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding. What happenedThe threat detection engine failed to produce results. Review the workflow run logs for details. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "api.individual.githubcopilot.com"See Network Configuration for more information.
|
|
✅ Ponytail Reviewer completed successfully! Lean already. Ship.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories (17 additions detected).
|
There was a problem hiding this comment.
Pull request overview
Adds kimi-k3 pricing metadata to the synchronized model catalogs. The changes are consistent, but the PR remains WIP with final validation and security checks incomplete.
Changes:
- Adds Copilot pricing and API metadata for
kimi-k3. - Tests embedded pricing lookup.
- Documents the catalog update.
Show a summary per file
| File | Description |
|---|---|
pkg/cli/model_costs_test.go |
Tests kimi-k3 pricing lookup. |
pkg/cli/data/models.json |
Adds the CLI catalog entry. |
actions/setup/js/models.json |
Mirrors the catalog entry for setup runtime. |
.changeset/patch-model-inventory-2026-08-10.md |
Records the patch release change. |
Review details
Tip
Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
|
Excellent work on the model catalog update! 🎉 This PR adds the The PR is well-focused on a single responsibility, includes test coverage for the model cost logic, and is properly documented with a linked issue. The changes align perfectly with the project's model maintenance workflow. ✅ Ready for review and merge!
|
There was a problem hiding this comment.
The kimi-k3 model addition looks correct: pricing values match the changeset description, both models.json copies are updated in sync, and the test exercises all three cost fields. No issues found.
🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 14.8 AIC · ⌖ 6.17 AIC · ⊞ 5.4K
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs — one inaccuracy in the changeset description to fix.
📋 Key Themes & Highlights
Key Themes
- Changeset inaccuracy: The changeset claims the existing
kimialias covers the new model, but no such alias exists inmodels.json.
Positive Highlights
- ✅ Test added alongside the data change, asserting all three cost dimensions
- ✅ Both synchronized inventories (
actions/setup/js/models.jsonandpkg/cli/data/models.json) updated identically - ✅ Changeset included with correct pricing figures
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 26.9 AIC · ⌖ 6.96 AIC · ⊞ 7.1K
Comment /matt to run again
| "gh-aw": patch | ||
| --- | ||
|
|
||
| Model alias inventory update for 2026-08-10: add `kimi-k3` ($3/1M input, $15/1M output, $0.30/1M cache read) to the `github-copilot` provider in `models.json`; the existing `kimi` alias already covers the new model. |
There was a problem hiding this comment.
[/grill-with-docs] The changeset states "the existing kimi alias already covers the new model" but no kimi alias exists in models.json — only kimi-k2.7-code alongside the new kimi-k3. This claim is inaccurate and could mislead reviewers.
💡 Suggestion
Remove the alias claim. Corrected text:
Model alias inventory update for 2026-08-10: add `kimi-k3` ($3/1M input, $15/1M output, $0.30/1M cache read) to the `github-copilot` provider in `models.json`.
@copilot please address this.
🧪 Test Quality Sentinel AnalysisPR: #51938 — "[WIP] Add kimi-k3 model to models.json" SummaryThis PR adds the Test Coverage
New Test DetailsTestFindKimiK3Pricing — Model pricing lookupClassification:
Implementation: func TestFindKimiK3Pricing(t *testing.T) {
pricing, ok := findModelPricing("github-copilot", "kimi-k3")
require.True(t, ok)
assert.InDelta(t, 0.000003, pricing["input"], 1e-12)
assert.InDelta(t, 0.000015, pricing["output"], 1e-12)
assert.InDelta(t, 0.0000003, pricing["cache_read"], 1e-12)
}Strengths:
Notes:
Quality Scoring BreakdownStatus✅ No violations — Build tags present, no mock library usage, appropriate assertion pattern Recommendation: APPROVE — This is a valid behavioral contract test appropriate for model inventory updates.
|
|
🎉 This pull request is included in a new release. Release: |
The models.dev catalog lists
kimi-k3, but the local Copilot pricing inventory did not. Existing wildcard aliases already cover the model.Model inventory
kimi-k3to both synchronized catalogs.Coverage