Add regression coverage for CLI strict-mode default - #54657
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Audit strict-mode default in regular CLI compile path
Add regression coverage for CLI strict-mode default
Aug 21, 2026
pelikhan
marked this pull request as ready for review
August 21, 2026 23:58
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CLI integration coverage ensuring compilation defaults to strict mode.
Changes:
- Tests rejection of write permissions without
--strict. - Includes unrelated generated workflow changes requiring separation or explanation.
Show a summary per file
| File | Description |
|---|---|
pkg/cli/compile_permissions_integration_test.go |
Adds strict-default regression coverage. |
.github/workflows/weekly-network-domains-audit.lock.yml |
Changes installer mode and detection timeout. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
| touch /tmp/gh-aw/threat-detection/detection.log | ||
| - name: Install AWF binary | ||
| run: bash "${RUNNER_TEMP}/gh-aw/actions/install_awf_binary.sh" v0.28.4 | ||
| run: bash "${RUNNER_TEMP}/gh-aw/actions/install_awf_binary.sh" v0.28.4 --rootless |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI exposes
--strictas an explicit override while workflow compilation is documented as strict by default unless frontmatter setsstrict: false. This adds coverage for the ordinary CLI path to prevent that contract from regressing.gh aw compileinvocation.contents: writefails strict validation without passing--strict.The expected diagnostic confirms strict mode rejects the write permission by default.