Improve cached logs reporting - #60430
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff
|
|
✅ Ponytail Reviewer completed successfully! Warning Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding. What happenedThe threat detection engine failed to produce results. Review the workflow run logs for details. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "ab.chatgpt.com"See Network Configuration for more information.
|
|
Warning Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding. What happenedThe threat detection engine failed to produce results. Review the workflow run logs for details.
|
|
No ADR enforcement needed: PR does not have the 'implementation' label and has <=100 new lines of code in business logic directories.
|
|
🧠 Matt Pocock Skills Reviewer failed during the skills-based review. Warning Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding. What happenedThe threat detection engine failed to produce results. Review the workflow run logs for details.
|
There was a problem hiding this comment.
🟡 Changes recommended
The three newly wired collection paths lack direct tests confirming their statistics are recorded and rendered correctly.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Improves cached-log collection visibility and simplifies Drain3 training output.
Changes:
- Tracks discovered, downloaded, and cached reports across collection paths.
- Renders cache statistics for
--cached-jsonl. - Removes internal Drain3 rebuild guidance.
File summaries
| File | Description |
|---|---|
pkg/cli/logs_orchestrator.go |
Renders single-target statistics. |
pkg/cli/logs_orchestrator_unit_test.go |
Tests statistics formatting. |
pkg/cli/logs_orchestrator_types.go |
Stores shared collection statistics. |
pkg/cli/logs_orchestrator_stdin.go |
Tracks stdin collection results. |
pkg/cli/logs_orchestrator_download.go |
Implements thread-safe statistics tracking. |
pkg/cli/logs_multi.go |
Renders aggregate multi-target statistics. |
pkg/cli/logs_cached_json.go |
Initializes statistics for cached JSONL use. |
pkg/cli/drain3_train.go |
Removes internal rebuild instructions. |
pkg/cli/drain3_train_test.go |
Verifies removed guidance stays absent. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| assert.LessOrEqual(t, status.timeoutRemaining, time.Minute) | ||
| } | ||
|
|
||
| func TestLogsCollectionStatsReportsDiscoveredDownloadedAndCached(t *testing.T) { |
|
@copilot this PR still needs forward progress.
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See Network Configuration for more information.
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Added path-level tests for all three entry points in the latest commits:
Each calls its real entry point with |
|
🎉 This pull request is included in a new release. Release: |
logs --cached-jsonldid not show how discovered runs were handled. Drain3 training also exposed internal rebuild instructions.Cache reporting
Drain3 output
make buildguidance.Run: https://github.com/github/gh-aw/actions/runs/34703679327
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
github.laiyagushi.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.