[docs] docs: unbloat imports reference - #60532
Merged
Merged
Conversation
This was referenced Sep 13, 2026
pelikhan
marked this pull request as ready for review
September 13, 2026 01:45
Contributor
Author
|
✅ Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. PR #60532 only modifies documentation (docs/src/content/docs/reference/imports.md). Test Quality Sentinel skipped.
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Two merge-semantics clarifications remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Condenses the imports reference documentation while preserving its technical guidance and examples.
Changes:
- Tightens shared-component and path-resolution explanations.
- Simplifies merge-strategy descriptions.
- Condenses
inlined-importsfailure-mode guidance.
File summaries
| File | Summary |
|---|---|
docs/src/content/docs/reference/imports.md |
Streamlines imports reference documentation; merge-semantics wording needs clarification. |
Review details
Suppressed comments (1)
docs/src/content/docs/reference/imports.md:329
- This shortened row no longer states that the importing workflow's own
engine.mcptimeout values take precedence, or that an imported value is used only when that timeout is unset. The paragraph below does, but the field-specific merge table is the reference summary; please keep that precedence rule in the row so the table is not misleading.
| `engine.mcp` | First-wins across imports. Shared files may define only `mcp.tool-timeout` and/or `mcp.session-timeout`; the importing workflow's engine identifier always wins. |
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
| | `engine.mcp` | First-wins across imports. Shared files may define `engine:` with only `mcp.tool-timeout` and/or `mcp.session-timeout` (no engine identifier). The importing workflow's own engine setting always takes precedence; the first imported value fills in if the main workflow does not set a value. | | ||
| | `services:` | All services merge; duplicate names fail compilation. | | ||
| | `github-app:` | Main takes precedence; otherwise the first imported value is used. | | ||
| | `checkout:` | Imported entries are appended after the main workflow's entries. For duplicate `(repository, path)` pairs, the main entry wins: first-seen wins for `ref`, auth is mutually exclusive, and `checkout: false` in the main workflow disables all checkout, including imported entries. | |
Contributor
Author
|
🎉 This pull request is included in a new release. Release: |
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/src/content/docs/reference/imports.mdBloat removed
inlined-importsfailure-mode explanation while preserving the concrete error casesEstimated reduction