Skip to content

Disable persisted credentials in auto-upgrade checkout #60650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Sep 13, 2026
Merged

Disable persisted credentials in auto-upgrade checkout #60650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/agentic-auto-upgrade.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Setup Go
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
Expand Down
2 changes: 2 additions & 0 deletions pkg/workflow/auto_update_workflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,8 @@ jobs:
steps:
- name: Checkout repository
uses: ` + getActionPin("actions/checkout") + `
with:
persist-credentials: false

` + installCLISteps + ` - name: Setup Scripts
uses: ` + setupActionRef + `
Expand Down
1 change: 1 addition & 0 deletions pkg/workflow/auto_update_workflow_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ func TestGenerateAutoUpdateWorkflow_Enabled(t *testing.T) {
assert.Contains(t, content, "GH_AW_OPERATION: upgrade", "should set upgrade operation")
assert.Contains(t, content, "GH_AW_CMD_PREFIX: ./gh-aw", "should use dev CLI prefix by default")
assert.Contains(t, content, "Checkout repository", "should include checkout step")
assert.Contains(t, content, "persist-credentials: false", "should not persist checkout credentials")
assert.Contains(t, content, "Build gh-aw", "should include local gh-aw build step in dev mode")
assert.Contains(t, content, "mainNotifyIssue", "should call mainNotifyIssue")
assert.NotContains(t, content, "uses: ./.github/workflows/agentics-maintenance.yml", "should not use workflow_call")
Expand Down
Loading