Disable credential persistence on the agentic_commands router checkout - #60685
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
Ensure agentic_commands.yml router checkout sets persist-credentials: false
Disable credential persistence on the agentic_commands router checkout
Sep 13, 2026
Copilot created this pull request from a session on behalf of
pelikhan
September 13, 2026 20:18
View session
pelikhan
marked this pull request as ready for review
September 13, 2026 20:19
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change consistently updates generator output, regression coverage, generated workflow, and release metadata.
Pull request overview
Prevents the generated slash-command router from persisting checkout credentials, reducing credential exposure.
Changes:
- Adds
persist-credentials: falseto the generated checkout step. - Adds focused regression coverage and regenerates the workflow.
- Adds a patch changeset.
File summaries
| File | Description |
|---|---|
pkg/workflow/central_slash_command_workflow.go |
Generates credential-free checkout configuration. |
pkg/workflow/central_slash_command_workflow_test.go |
Verifies credentials are not persisted. |
.github/workflows/agentic_commands.yml |
Applies the regenerated secure checkout block. |
.changeset/central-commands-checkout-no-credentials.md |
Records the security hardening change. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced (auto)
Note
Copilot is running an experiment and ran this review at Balanced.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated central slash-command router workflow (
.github/workflows/agentic_commands.yml) checked out the repo withoutpersist-credentials: false, leavingGITHUB_TOKENin the local git config for the lifetime of the routing job. The router only needs the tree (it loadsactions/setupscripts and dispatches), so persisted credentials are pure blast radius.Changes
pkg/workflow/central_slash_command_workflow.go— emitwith: persist-credentials: falseon the router'sactions/checkoutstep.pkg/workflow/central_slash_command_workflow_test.go—TestGenerateCentralSlashCommandWorkflow_CheckoutDoesNotPersistCredentialsasserts the full checkout block (step name + pinneduses+with) and thatpersist-credentials: truenever appears in the generated output..github/workflows/agentic_commands.yml— regenerated viamake recompile.Generated output:
Note: the custom Go linter reports function-length and path-concatenation findings in
central_slash_command_workflow.go. These reproduce on the unmodified baseline and are left untouched.