Fix clean-checkout test and lint failures - #61105
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The purity regression no longer verifies that the required actions: write exception remains allowed.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced
Findings: 1
Open (1)
What changed in this PR
Fixes clean-checkout test and lint failures across workflow validation and setup tooling.
Changes:
- Configures prompt fixtures for version-update tests.
- Updates conformance and workflow-purity expectations.
- Applies Go modernization fixes and adds a patch changeset.
| File | Description |
|---|---|
.changeset/patch-fix-local-test-lint.md |
Records the patch-level maintenance fix. |
actions/setup/js/check_version_updates.test.cjs |
Configures and restores runtime prompt paths. |
pkg/cli/logs_orchestrator_unit_test.go |
Uses fmt.Appendf for byte fixtures. |
pkg/workflow/cloud_hypervisor_test.go |
Modernizes JSON fixture construction. |
pkg/workflow/template_injection_validation_benchmark_test.go |
Uses the modern benchmark loop API. |
scripts/check-cgo-cjs-workflow-purity_test.sh |
Uses a forbidden flow-style permission fixture. |
scripts/check-safe-outputs-conformance_test.sh |
Expects complete safe-output schema coverage. |
| steps: | ||
| - run: echo ok" | ||
| write_workflow "$T4_CJS" " permissions: { contents: read, actions: 'write' } | ||
| write_workflow "$T4_CJS" " permissions: { contents: read, issues: 'write' } |
There was a problem hiding this comment.
Added a separate passing actions: write workflow fixture in scripts/check-cgo-cjs-workflow-purity_test.sh. The forbidden flow-style issues: write coverage remains unchanged. Fixed in 264e841.
|
Thanks @dsyme for fixing these local test and lint failures! 🎯 The PR is well-focused, properly documented with clear validation steps ( Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See Network Configuration for more information.
|
|
@copilot Please take another pass on this PR and run the There is still an open Copilot review finding on the current work:
Please either push the follow-up fix or summarize the remaining blocker for maintainers. Run: https://github.com/github/gh-aw/actions/runs/35009433262
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Added the separate passing |
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
|
@copilot Please take another pass on this PR and run the Outstanding follow-up items on the current head:
Please either push the remaining fix, resolve the thread if addressed, or summarize the blocker for maintainers. Run: https://github.com/github/gh-aw/actions/runs/35036703499 Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See Network Configuration for more information.
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
The branch refresh is present in merge commit bd15395. I reproduced the |
|
🎉 This pull request is included in a new release. Release: |
Summary
check_version_updatestests so blocked-version issue cases work without ambient runner environmentgolintactions: writeallowanceValidation
make test-allmake lintBoth pass locally on a clean checkout. The CJS linter continues to report its existing non-fatal warnings.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
github.laiyagushi.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.