Skip to content

Update lethal trifecta landing page copy - #65115

Merged
pelikhan merged 7 commits into
mainfrom
copilot/update-lethal-trifecta-copy
Oct 3, 2026
Merged

pelikhan merged 7 commits into
mainfrom
copilot/update-lethal-trifecta-copy

Conversation

Copilot AI commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Revise the landing page’s lethal-trifecta copy to describe gh-aw’s six security layers and update the threat and control labels.

  • Diagram labels: Update the descriptions for private data, untrusted content, and outbound access, and rename the relevant controls to “Isolated sandbox” and “Agent firewall.”
  • Accessibility: Align the screen-reader caption with the updated labels.

Branch refresh requested by PR Sous Chef. Run: https://github.com/github/gh-aw/actions/runs/37074045850

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 14.9 AIC · ⌖ 8.58 AIC · ⊞ 9.7K · ◷
Comment /souschef to run again

Copilot AI linked an issue Oct 2, 2026 that may be closed by this pull request
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot AI changed the title [WIP] Update lethal trifecta landing page copy Update lethal trifecta landing page copy Oct 2, 2026
Copilot AI requested a review from lpcox October 2, 2026 22:12
@lpcox

lpcox commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

@copilot replace "Issues, PR comments" with "Issues and PR comments"

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Copilot AI commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

@copilot replace "Issues, PR comments" with "Issues and PR comments"

Updated the label to “Issues and PR comments” in commit 8c7f4f4.

@lpcox
lpcox marked this pull request as ready for review October 2, 2026 22:27
Copilot AI balanced review requested due to automatic review settings October 2, 2026 22:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The untrusted-content label does not match the copy explicitly required by the linked issue.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Updates the lethal-trifecta landing section to describe gh-aw’s six security layers and revised security terminology.

Changes:

  • Revises threat and control labels.
  • Updates explanatory and screen-reader copy.
File Description
docs/​src/​components/​landing/​SafeByDefaultTrifecta.astro Updates diagram labels, introduction, and accessible caption.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/src/components/landing/SafeByDefaultTrifecta.astro
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot Please take another pass on this PR. Please refresh the branch if needed, address any outstanding review feedback, and then run the pr-finisher skill before handing back to maintainers.

Generated by 👨🍳 PR Sous Chef
Comment /souschef to run again

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 14.9 AIC · ⌖ 8.58 AIC · ⊞ 9.7K · ◷
Comment /souschef to run again

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Please take another pass on this PR. Please refresh the branch if needed, address any outstanding review feedback, and then run the pr-finisher skill before handing back to maintainers.

...

Updated the visible label to match issue #65114 in commit 0bd7e08. Formatting, lint, recompilation, impacted tests, and the docs build passed; make test hit an unrelated existing concurrent Cobra completion-test panic. CI needs a maintainer re-trigger after this push.

Copilot AI requested a review from gh-aw-bot October 2, 2026 23:09
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot Please take another pass on this PR. Review feedback appears addressed in follow-up replies, but the review thread is still unresolved. Please verify the current head, resolve any remaining review feedback, refresh the branch if needed, and then run the pr-finisher skill before handing back to maintainers.

Generated by 👨🍳 PR Sous Chef
Comment /souschef to run again

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 17.7 AIC · ⌖ 8.68 AIC · ⊞ 9.2K · ◷
Comment /souschef to run again

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor Author

@copilot Please take another pass on this PR. Review feedback appears addressed in follow-up replies, but the review thread is still unresolved. Please verify the current head, resolve any remaining r...

Verified the linked Copilot review thread is resolved and its concern was answered in-thread. Updated the label per lpcox’s latest request in 33dbf42; formatting, lint, tests, workflow recompilation, docs build, and final pre-push validation passed. The branch was already current with main; checks on the new head are unverified and need a maintainer re-trigger.

@copilot replace "Issues, PR comments" with "Issues and PR comments"

Updated the visible label to “Issues and PR comments” in commit 33dbf42.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot Please review this PR for forward progress: check unresolved review feedback, failed checks, and whether the branch needs a refresh. If action is needed, please continue with the pr-finisher skill.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 11.4 AIC · ⌖ 8.58 AIC · ⊞ 9.4K · ◷
Comment /souschef to run again

…-trifecta-copy

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Please review this PR for forward progress: check unresolved review feedback, failed checks, and whether the branch needs a refresh. If action is needed, please continue with the pr-finisher ...

Refreshed the branch with latest main in merge commit cf1c8ad (it was four commits behind). The requested copy is intact, and the only review thread is resolved. Local make fmt, make lint, make test-unit, make test, and make recompile passed. The latest completed checks on the prior head (docs build, visual regression, and code scanning) passed; no failed jobs were found in the older action-required runs. The Copilot check was still in progress and is stale after this merge, so a maintainer must re-trigger CI; human review is still needed.

@pelikhan
pelikhan merged commit 46e10e2 into main Oct 3, 2026
1 check passed
@pelikhan
pelikhan deleted the copilot/update-lethal-trifecta-copy branch October 3, 2026 02:21
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.91.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update lethal trifecta landing page copy

5 participants