Skip to content

Include WorkQ claims in the admission prompt - #65192

Merged
pelikhan merged 4 commits into
mainfrom
copilot/update-admission-js-workq-claim
Oct 3, 2026
Merged

pelikhan merged 4 commits into
mainfrom
copilot/update-admission-js-workq-claim

Conversation

Copilot AI commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

The admission prompt did not expose an inbound WorkQ claim, leaving the agent without its assigned work or a clear completion signal.

  • Claim context: Render the work payload and claim identity under <WorkQ> and <WorkClaim> tags. Prompts without a claim remain unchanged.
  • Completion: Tell the agent to record a completed or cancelled finish intent with dispatch_claim_finish, while making clear that trusted reconciliation determines whether the claim is complete.
  • Boundary: Escape tag-like text in the work payload so it cannot break the prompt’s section structure.

Copilot AI and others added 2 commits October 3, 2026 01:13
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Include WorkQ claim context in admission prompt Include WorkQ claims in the admission prompt Oct 3, 2026
Copilot AI requested a review from pelikhan October 3, 2026 01:16
@pelikhan

pelikhan commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

@copilot WorkQ -> work-claim

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

@copilot WorkQ -> work-claim

Renamed the prompt payload boundary to <work-claim> and updated the escaping test in 0359099.

@pelikhan

pelikhan commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

@copilot

  • remove nested
  • rename aw_context dispatch_work_coordinator to work_claim

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor Author

@copilot

  • remove nested
  • rename aw_context dispatch_work_coordinator to work_claim

Removed the separate claim wrapper and renamed the inbound aw_context field to work_claim in both prompt rendering and admission validation. Commit: c44381c.

@copilot WorkQ -> work-claim

The prompt uses <work-claim> as requested (commit 0359099).

@pelikhan
pelikhan marked this pull request as ready for review October 3, 2026 02:16
Copilot AI balanced review requested due to automatic review settings October 3, 2026 02:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The emitted tags conflict with the documented separate <WorkQ> and <WorkClaim> prompt contract.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Adds inbound WorkQ claim details and completion guidance to agent prompts.

Changes:

  • Reads work_claim from inbound context.
  • Adds escaped claim data and finish instructions to user prompts.
  • Updates snapshot handling and tests.
File Description
actions/​setup/​js/​aw_context.cjs Exports inbound-context reader.
actions/​setup/​js/​create_prompt.cjs Renders claim context and guidance.
actions/​setup/​js/​create_prompt.test.cjs Tests claim rendering and escaping.
actions/​setup/​js/​write_dispatch_work_coordinator_snapshot.cjs Reads the renamed claim field.
actions/​setup/​js/​write_dispatch_work_coordinator_snapshot.test.cjs Updates assignment fixtures.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread actions/setup/js/create_prompt.cjs
@pelikhan
pelikhan merged commit de6e5b9 into main Oct 3, 2026
13 checks passed
@pelikhan
pelikhan deleted the copilot/update-admission-js-workq-claim branch October 3, 2026 02:22
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.91.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants