Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Collaborator
|
@copilot refactor the validation script as a shell script in the actions/setup/sh folder and invoke with arguments. |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Validate MCP gateway rewrites config file with gatewayed servers
Add validation for gatewayed MCP servers in health check
Jan 2, 2026
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Refactored the validation to use a shell script in commit 24ab794. Created The generated workflow is now much cleaner - instead of ~30 lines of inline validation per server, it's now a single line: /tmp/gh-aw/actions/validate_gatewayed_server.sh "github" "/home/runner/.copilot/mcp-config.json" "http://localhost:8080" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored Validation to Use Shell Script
validate_gatewayed_server.shinactions/setup/sh/gateway.goto invoke shell script instead of inline validationChanges
New Shell Script:
actions/setup/sh/validate_gatewayed_server.shRefactored:
pkg/workflow/gateway.go/tmp/gh-aw/actions/validate_gatewayed_server.sh "github" "/home/runner/.copilot/mcp-config.json" "http://localhost:8080"Updated:
pkg/workflow/gateway_test.goBefore (inline validation)
After (shell script invocation)
This makes the generated workflow much cleaner and the validation logic easier to maintain and test independently.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.