Updates missing .phpunit.cache dir for newer laravel#4873
Open
lissy93 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Laravel.gitignore template to match newer Laravel/PHPUnit defaults by ignoring the PHPUnit cache directory introduced as the default location for test cache data.
Changes:
- Add
/.phpunit.cacheto ignore PHPUnit 10+ cache directory while retaining.phpunit.result.cachefor older PHPUnit versions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to the application or project's homepage
https://laravel.com/
Reasons for making this change
laravel moved the default location for test results and coverage cache back in 2023, to just
.phpunit.cache.The old
.phpunit.result.cacheis still useful for projects using PHPUnit 9 or below, so I didn't touch that.Links to documentation supporting these rule changes
Official Laravel
.gitignore: https://github.com/laravel/laravel/blob/master/.gitignore#L11(added in laravel/laravel#6052, during the PHPUnit 10 upgrade)
Merge and Approval Steps