Skip to content

Fix panic on Windows#35

Merged
btoews merged 2 commits into
masterfrom
bump-certstore
Nov 8, 2018
Merged

Fix panic on Windows#35
btoews merged 2 commits into
masterfrom
bump-certstore

Conversation

@btoews

@btoews btoews commented Nov 7, 2018

Copy link
Copy Markdown
Contributor

I'm hoping that github/certstore#10 will fix #33. This branch is building smimesign with that branch from the certstore repo.

@maufl would you mind downloading the version of smimesign building from this branch and checking if this fixes the error you were seeing? You can find the build artifacts here.

@maufl

maufl commented Nov 8, 2018

Copy link
Copy Markdown

Looks good. Doesn't crash anymore and provides a good error message.

$ git commit -S
failed to get idenity signer: failed to load identity private key: failed to get private key for certificate
error: gpg failed to sign the data
fatal: failed to write commit object

@btoews

btoews commented Nov 8, 2018

Copy link
Copy Markdown
Contributor Author

Great. Thanks for your help in debugging this.

@maufl

maufl commented Nov 8, 2018

Copy link
Copy Markdown

Thanks for fixing it so quickly!

@btoews btoews merged commit a35b79e into master Nov 8, 2018
@btoews btoews deleted the bump-certstore branch November 8, 2018 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic if smart card not present

2 participants