fix: enforce semantic titles after meta agent removal - #83
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR adds Conventional Commits enforcement to the repository through a local git hook, GitHub Actions workflow, commitlint configuration, Makefile installation target, and updated contributor documentation. Developers commit locally with format validation via the commit-msg hook, and PR titles are also validated at the CI level before merge. ChangesConventional Commits Enforcement
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.githooks/commit-msg:
- Line 20: The current grep pattern that checks the variable output in the
commit-msg hook only matches messages that start with "npm ERR!" or "npm error"
and therefore misses alternative npx error formats like "Error: could not
determine executable"; update the grep regex used on the output variable (the
line containing printf '%s\n' "$output" | grep -qE '...') to also accept common
non-"npm ERR!" prefixes (for example allow an optional leading "npm (ERR!|error)
" or other prefixes like "Error:"), so the check will detect
network/resolution/executable errors regardless of whether they include the "npm
ERR!" prefix; keep the rest of the conditional logic unchanged.
In `@Makefile`:
- Around line 57-59: The three ln commands creating symlinks for commit-msg,
pre-commit, and pre-push currently use absolute paths via
"$$(pwd)/.githooks/..." which makes them non-portable; change them to create
relative symlinks instead (point the hooks to ".githooks/commit-msg",
".githooks/pre-commit", ".githooks/pre-push" or compute the repository root with
git and form paths relative to the hooks directory) so the symlinks remain valid
if the repo is moved or re-cloned; update the three ln -sf lines that reference
the .githooks files to use these relative paths.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 5952a2bf-637b-42fd-8cd7-87a8c5f0adb2
📒 Files selected for processing (5)
.githooks/commit-msg.github/workflows/semantic-pr-title.ymlCONTRIBUTING.mdMakefilecommitlint.config.cjs
Summary
Release notes
This PR intentionally uses a conventional
fix:title mentioning the meta agent removal so the next release notes include the work from PR #81 / dffe7aa, whose merged GitHub subject was not conventional.Verification
.githooks/commit-msgacceptsfix: remove legacy meta agent workspace entry [[tasks/harmony-678]].githooks/commit-msgrejectsAlign workspace after meta agent removal (#81)cargo fmt --all -- --checkcargo test --workspacehit existing git_utils test worktree mutation/lock failures unrelated to this workflow/doc/hook changeSummary by CodeRabbit
Chores
make install-hookscommand for developers to configure local validation.