Skip to content

Align workspace after meta agent removal - #81

Merged
mateodelnorte merged 2 commits into
mainfrom
harmony-678-meta-agent-removal
May 19, 2026
Merged

mateodelnorte merged 2 commits into
mainfrom
harmony-678-meta-agent-removal

Conversation

@mateodelnorte

@mateodelnorte mateodelnorte commented May 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • update the workspace lockfile after removing meta_cli guard dependencies
  • update top-level init.bats expectations from meta agent guard to agent guard
  • align top-level Claude safety wording with the standalone agent command

Companion PR

Verification

  • cargo test -p meta
  • bats tests/init.bats
  • ./target/debug/meta --help no longer lists agent
  • ./target/debug/meta agent guard exits unrecognized

Task: [[tasks/harmony-678]]

Summary by CodeRabbit

  • Documentation
    • Clarified safety rules wording: the blocked-by guidance now appears under “Blocked by agent guard” to clarify which guard enforces denials for destructive operations.
  • Tests
    • Updated integration test expectations to look for “agent guard” and assert that “meta agent guard” is no longer present.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 19, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ad2a177e-7ec9-4458-99e7-2be48832be07

📥 Commits

Reviewing files that changed from the base of the PR and between 3652dfe and 6a86139.

📒 Files selected for processing (1)
  • tests/init.bats

Walkthrough

This PR renames the guard reference from "meta agent guard" to "agent guard" in the destructive-commands documentation and updates the integration test to assert the new wording (and assert the old wording is absent).

Changes

Guard name clarification

Layer / File(s) Summary
Guard name update in documentation and tests
.claude/rules/meta-destructive-commands.md, tests/init.bats
Section header changed from "Blocked by meta agent guard" to "Blocked by agent guard"; test assertion updated to check for "agent guard" and to assert "meta agent guard" is not present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nibbled words until they were spare,
Dropped "meta" so the meaning's fair,
Docs and tests hop in line,
"agent guard" now reads just fine,
A tidy change — a carrot's share.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Align workspace after meta agent removal' directly relates to the primary changes: updating references from 'meta agent guard' to 'agent guard' in documentation and tests after removing meta agent functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch harmony-678-meta-agent-removal

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/init.bats`:
- Around line 84-87: The test "init claude settings references agent guard"
currently only greps for "agent guard" which will also match the old phrase
"meta agent guard"; update the test in tests/init.bats (the `@test` block named
"init claude settings references agent guard") to strengthen the assertion by
either adding an explicit negative check that ensures "meta agent guard" is not
present (e.g., run grep -q "meta agent guard" and assert failure) or replace the
grep with an exact match/assertion for the full expected sentence in
.claude/settings.json so the test fails when the legacy wording remains.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f82ee852-180d-429d-8fb5-bccc36033ff3

📥 Commits

Reviewing files that changed from the base of the PR and between aa4b854 and 3652dfe.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .claude/rules/meta-destructive-commands.md
  • tests/init.bats

Comment thread tests/init.bats
@mateodelnorte
mateodelnorte merged commit dffe7aa into main May 19, 2026
8 checks passed
mateodelnorte added a commit that referenced this pull request May 19, 2026
* fix: enforce semantic titles after meta agent removal [[tasks/harmony-678]]

Release-note follow-up for PR #81 / dffe7aa, whose GitHub merge subject was not conventional.

* fix: resolve semantic title review comments [[tasks/harmony-678]]

---------

Co-authored-by: Test <test@test.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant