Skip to content

fix: use version-file for VERSION in release-please - #33

Merged
mateodelnorte merged 1 commit into
mainfrom
fix/release-please-version-file
Feb 17, 2026
Merged

mateodelnorte merged 1 commit into
mainfrom
fix/release-please-version-file

Conversation

@mateodelnorte

@mateodelnorte mateodelnorte commented Feb 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Switch from extra-files with generic type to version-file: "VERSION" in release-please config
  • Remove the sync-version post-merge workaround job from on-push-main.yml
  • trigger-release now depends directly on release-please instead of sync-version

Context

The generic type in extra-files requires x-release-please-version markers in the file, which the plain VERSION file doesn't have. This meant release-please never updated VERSION, requiring a separate sync-version job to run after merge. The version-file option handles plain text version files natively, so VERSION gets updated directly in the release PR.

Fixes the issue noted in #30.

Test plan

  • Next release PR should include VERSION file update
  • Release workflow triggers correctly without sync-version job

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Streamlined release automation by consolidating version management configuration.
    • Removed intermediate version synchronization step from release workflow for more efficient builds.

The `generic` type in `extra-files` requires `x-release-please-version`
markers in the file, which VERSION does not have. Switch to
`version-file: "VERSION"` which handles plain text version files
natively, so release-please updates VERSION directly in the release PR.

This eliminates the separate `sync-version` post-merge job that was
working around this limitation.

Co-authored-by: Claude <claude@anthropic.com>
@coderabbitai

coderabbitai Bot commented Feb 17, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉


Walkthrough

The pull request streamlines the version file handling process by removing the dedicated sync-version GitHub Actions job and updating the release-please configuration to use a version-file directive instead of an extra-files entry, simplifying the release workflow.

Changes

Cohort / File(s) Summary
Release Workflow Simplification
.github/workflows/on-push-main.yml
Removes the sync-version job that handled VERSION file updates before release; updates trigger-release job to remove dependency on sync-version, streamlining the workflow from two steps to one.
Version File Configuration
release-please-config.json
Replaces the extra-files generic entry for VERSION with a dedicated version-file directive, centralizing version source configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Poem

🐰 The sync-job hops away with glee,
Release-please handles VERSION, you see!
One less step in the workflow's dance,
Configuration blooms—a cleaner advance! ✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: using version-file configuration in release-please instead of the previous extra-files approach, and aligns with the primary objectives of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/release-please-version-file

Comment @coderabbitai help to get the list of available commands and usage tips.

@mateodelnorte
mateodelnorte merged commit 949db93 into main Feb 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant