fix: use version-file for VERSION in release-please - #33
Merged
Merged
Conversation
The `generic` type in `extra-files` requires `x-release-please-version` markers in the file, which VERSION does not have. Switch to `version-file: "VERSION"` which handles plain text version files natively, so release-please updates VERSION directly in the release PR. This eliminates the separate `sync-version` post-merge job that was working around this limitation. Co-authored-by: Claude <claude@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 WalkthroughThe pull request streamlines the version file handling process by removing the dedicated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extra-fileswithgenerictype toversion-file: "VERSION"in release-please configsync-versionpost-merge workaround job fromon-push-main.ymltrigger-releasenow depends directly onrelease-pleaseinstead ofsync-versionContext
The
generictype inextra-filesrequiresx-release-please-versionmarkers in the file, which the plainVERSIONfile doesn't have. This meant release-please never updated VERSION, requiring a separatesync-versionjob to run after merge. Theversion-fileoption handles plain text version files natively, so VERSION gets updated directly in the release PR.Fixes the issue noted in #30.
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit