test(worktree): update tests for destroy→remove rename

[mateodelnorte]

Summary

• Updates all BATS worktree tests to use remove as the primary command
• Adds dedicated test verifying destroy still works as a hidden alias
• Updates help text assertions to check for remove instead of destroy

Context

Companion to gitkb/meta_git_cli#17 — part of [[tasks/meta-63]].

Test plan

• All 66 BATS tests pass (bats tests/worktree.bats)
• Alias test (fix: use PARENT_REPO_PAT for sync commits to protected main #42) confirms destroy backward compat

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Updated test suite to rename "destroy" workflows to "remove" across scenarios and help output.
  • Adjusted lifecycle, TTL, centralized-store, hook, prune, ephemeral and multi-repo tests to use the new terminology.
  • Added/updated edge-case and alias tests to verify alias paths and removal behavior remain correct.

[coderabbitai]

Walkthrough

Tests updated to replace all "destroy" terminology with "remove" for git worktree operations, including command invocations, test names, directory references, and help output expectations; no functional test behavior changes.

Changes

Cohort / File(s)	Summary
Worktree tests tests/worktree.bats	Replaced git worktree destroy with git worktree remove across tests. Updated test names, directory expectations (e.g., .worktrees/dot-destroy → .worktrees/dot-remove), help-output text, edge-case assertions, and alias-related checks.
Cloud/worktree integration tests tests/worktree_cloud.bats	Replaced git worktree destroy with git worktree remove in TTL, centralized-store, hook, prune, ephemeral, lifecycle, and JSON-output tests. Updated help-output expectation from "DESTROY OPTIONS" to "REMOVE OPTIONS" and adjusted related test descriptions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through tests both near and far,
Swapped "destroy" for "remove" on every bar.
Names refreshed and paths made neat,
The same old logic, a lighter feet —
A tidy change, a tiny carrot star.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately and concisely summarizes the main change: updating tests to reflect a command rename from destroy to remove in the worktree functionality.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch rename-worktree-destroy-to-remove

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

Greptile Summary

Updates all worktree tests to use remove as the primary command name instead of destroy, aligning tests with the CLI refactoring in gitkb/meta_git_cli#17.

• Renamed test functions and commands from destroy to remove (6 test cases)
• Updated help text assertions to check for remove instead of destroy
• Added new test case (fix: use PARENT_REPO_PAT for sync commits to protected main #42) verifying destroy alias still functions for backward compatibility
• Updated test names and inline comments for consistency (e.g., multi-destroy → multi-remove, dot-destroy → dot-remove)
• Updated section headers and test descriptions throughout

Confidence Score: 5/5

• This PR is safe to merge with no risk
• Test-only changes with systematic rename from destroy to remove, comprehensive backward compatibility test added, all assertions properly updated, no logic changes
• No files require special attention

Important Files Changed

Filename	Overview
tests/worktree.bats	Renames all destroy commands to remove in test suite and adds backward compatibility test for destroy alias

_{Last reviewed commit: 9d5c3e8}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tests/worktree.bats`:
- Around line 376-428: In the "worktree remove preserves branches" test, the
remove call isn't checking its exit status; invoke the remove using the test
harness (use run "$META_BIN" git worktree remove keep-branch or capture $?
immediately) and add an assertion like [ "$status" -eq 0 ] (or equivalent)
before the subsequent git branch check to ensure the remove succeeded.

[mateodelnorte]

Note: Merge ordering dependency

The integration tests fail because CI clones meta_git_cli from main, which still has destroy as the primary command. Tests that check for remove in help output naturally fail against the old binary.

Merge order: gitkb/meta_git_cli#17 first, then this PR. Integration tests will pass once CI picks up the updated meta_git_cli from main.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

tests/worktree_cloud.bats (1)

295-318: 🧹 Nitpick | 🔵 Trivial

Stale comment: "Destroy" should be "Remove".

The inline comment at line 307 still says # Destroy but the command now uses remove. Update for consistency.

✏️ Suggested fix

     python3 -c "
 import json
 with open('\$STORE') as f:
     data = json.load(f)
 assert any(v['name'] == 'store-rm' for v in data['worktrees'].values())
 "

-    # Destroy
+    # Remove
     run "\$META_BIN" git worktree remove store-rm

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/worktree_cloud.bats` around lines 295 - 318, In the "@test \"worktree
remove removes from centralized store\"" test update the inline comment that
currently reads "# Destroy" to match the command and intent by changing it to "#
Remove"; locate the block around the call to run "$META_BIN" git worktree remove
store-rm and replace that single-line comment so the test comments remain
consistent with the remove operation.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@tests/worktree_cloud.bats`:
- Around line 295-318: In the "@test \"worktree remove removes from centralized
store\"" test update the inline comment that currently reads "# Destroy" to
match the command and intent by changing it to "# Remove"; locate the block
around the call to run "$META_BIN" git worktree remove store-rm and replace that
single-line comment so the test comments remain consistent with the remove
operation.