Skip to content

feat: forward Cargo commands through Meta CLI - #97

Closed
Gonzih wants to merge 4 commits into
mainfrom
tasks--meta-cargo-command-forwarding
Closed

Gonzih wants to merge 4 commits into
mainfrom
tasks--meta-cargo-command-forwarding

Conversation

@Gonzih

@Gonzih Gonzih commented Jul 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • forward arbitrary meta cargo ... and meta rust ... requests through the Rust plugin
  • keep all Cargo/Rust command semantics, project selection, help, filtering, deduplication, and shell serialization in meta_rust_cli
  • keep meta_cli domain-neutral through additive protocol capabilities and generic plan execution policy
  • preserve Loop aliases for legacy callers while trusted plugin plans can disable alias expansion
  • ship meta-rust in release archives, shell/PowerShell installers, Homebrew, and the crates publishing workflow
  • document the first-pass ownership boundary: Meta owns --recursive before Cargo's --

Implements [[tasks/meta-cargo-command-forwarding]]

Coordinated PRs

  1. meta_plugin_protocol #5
  2. loop_lib #12
  3. meta_cli #31
  4. meta_rust_cli #14

Closed meta_cli #29 and #30 are superseded and remain closed.

ATC review/fix findings addressed

  • removed all Cargo/Rust production logic and fixtures from meta_cli
  • preserved legacy protocol Rust source and JSON compatibility with additive capability-aware types
  • preserved existing meta_rust_cli library entry points
  • kept prefix help host-owned while nested and declared bare help remain plugin-owned and config-free
  • retained separator payloads and hardened Windows cmd.exe execution boundaries
  • fixed the P1 release gap that omitted meta-rust from production distributions

Verification

  • protocol tests + warnings-denied Clippy
  • sibling plugin source-compatibility check
  • host policy tests (7), host binary tests (120), warnings-denied Clippy
  • Rust plugin tests (19 unit + 2 subprocess), warnings-denied Clippy
  • bats --print-output-on-failure tests/cargo.bats tests/help.bats tests/release_packaging.bats (23/23)
  • release build probe: cargo build --release -p meta_rust_cli and meta-rust --meta-plugin-info
  • installer shell syntax, Homebrew Ruby syntax, and workflow YAML parsing

Known baseline

The full-workspace Clippy job on Rust 1.97 stops in unchanged meta_core/src/config.rs:159 (clippy::question_mark). All changed packages pass warnings-denied Clippy; functional and OS CI jobs are expected to remain green.

Do not merge automatically.

Implements [[tasks/meta-cargo-command-forwarding]]
@coderabbitai

coderabbitai Bot commented Jul 14, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@Gonzih, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 22 seconds

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 397e73d1-44f4-401d-a149-6731f28d4a1a

📥 Commits

Reviewing files that changed from the base of the PR and between 4d8adcc and c858f61.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (11)
  • .github/workflows/ci.yml
  • .github/workflows/release.yml
  • README.md
  • distribution/homebrew/meta-cli.rb
  • docs/advanced_usage.md
  • docs/architecture_overview.md
  • install.ps1
  • install.sh
  • tests/cargo.bats
  • tests/help.bats
  • tests/release_packaging.bats
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tasks--meta-cargo-command-forwarding

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Implements [[tasks/meta-cargo-command-forwarding]]

Related: [[tasks/harmony-677]]
@Gonzih

Gonzih commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

ATC PR Evidence

Intent

  • ATC coordinated implementation completed across protocol, Loop, generic host, Rust plugin, and parent integration PRs.
  • ATC review found a P1 production distribution gap: meta-rust was not shipped by release archives or supported installers.
  • Fix commit c858f61 adds release builds/packages, installers, Homebrew, crates publishing, CI binary verification, and static release regressions.
  • Focused verification: 23/23 Bats, 19 Rust unit tests, 2 subprocess tests, 7 generic host policy tests, 120 host binary tests, and changed-package Clippy.
  • No PR was merged and auto-merge remains disabled.

Scope

Layer File / area Change
Runtime n/a No scoped file evidence was provided.

Evidence

Kind Source Result Confidence
Generated local ATC renderer No verification rows were provided. low
Run metadata and source links

Links

  • Task: tasks/meta-cargo-command-forwarding
  • PR

Metadata

Key Value
task tasks/meta-cargo-command-forwarding
pr #97

@Gonzih Gonzih closed this Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant