feat(config): add find_root_meta_dir() for ancestor discovery - #5
Conversation
Walks up through parent .meta configs to find the topmost meta directory in the hierarchy. Used by `meta project list --recursive` to start from the root ancestor instead of the nearest meta-repo. Implements [[tasks/meta-65]] Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 WalkthroughA new public utility function Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
Greptile SummaryAdds Changes:
Notes:
Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| src/config.rs | Added find_root_meta_dir() function with comprehensive test coverage (3 tests); implementation looks solid with minor consideration for edge case handling |
Last reviewed commit: f12f19b
parent() on a file path should always succeed, so use expect() to surface unexpected errors instead of silently falling back to ".". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Addressed review feedback: replaced |
Summary
find_root_meta_dir()that walks up through parent.metaconfigs to find the topmost meta directory in the hierarchymeta project list --recursive(in meta_project_cli) to start from the root ancestor instead of the nearest meta-repoTest plan
cargo test -p meta_core -- find_root_meta_dir— 3/3 passingcargo test --workspace— 652 tests, 0 failures🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Tests