fix: simplify notify-downstream workflow

[mateodelnorte]

Summary

• Remove broken commit message parsing that fails on merge commits with parentheses (e.g., feat: thing (#4))
• Remove checkout step (not needed for dispatch)
• Skip wait-for-ci on forwarded dispatches (already passed upstream)
• Upgrade peter-evans/repository-dispatch to v4
• Minimal payload: just repo, sha, actor

Context

The old workflow used MSG=$(git log -1 --pretty=%s) and bash regex matching to extract commit type. Commit subjects containing () (like GitHub merge commits with PR numbers) caused unexpected EOF while looking for matching ')' errors, breaking all downstream notifications.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Rate limit exceeded

@mateodelnorte has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 8 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: bac61657-a3dd-4477-8ac5-08f598d8e5d0

📥 Commits

Reviewing files that changed from the base of the PR and between 11bb723 and 6b8b457.

📒 Files selected for processing (1)

• .github/workflows/notify-downstream.yml

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/project-dependents

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

Greptile Summary

This PR simplifies the notify-downstream workflow by removing a fragile bash commit-message parser that broke on merge commits containing parentheses (e.g., feat: thing (#4)), and adds support for forwarding incoming repository_dispatch events through the dependency chain without re-waiting on CI.

Key changes:

• Root-cause fix: Eliminates the git log -1 --pretty=%s + bash regex block that caused unexpected EOF parse errors on PR-number suffixes in commit subjects.
• Chain forwarding: The workflow now also triggers on repository_dispatch(dependency-updated), enabling meta_plugin_protocol to sit in the middle of a multi-repo dependency notification chain.
• Correct skip logic: wait-for-ci is guarded with if: github.event_name == 'push'; the notify job uses if: always() && (... == 'success' || ... == 'skipped') to correctly handle both the push and repository_dispatch paths.
• Payload simplification: The dispatched payload is reduced to {repo, sha, actor} — removing repo_name, short_sha, message, and type. Downstream workflows that reference these removed fields will silently receive null without dispatch failure, so coordination with consumers is advisable.
• Dependency upgrade: peter-evans/repository-dispatch upgraded from v3 → v4.

Confidence Score: 4/5

• Safe to merge once downstream payload compatibility is confirmed — the core bug fix is correct and the workflow logic is sound.
• The PR correctly fixes a real bash-parsing bug, the conditional skip/forward logic is properly implemented, and the action upgrade is straightforward. The only non-blocking concern is the silent removal of payload fields that downstream repos may reference — but this is a coordination issue rather than a workflow correctness bug.
• .github/workflows/notify-downstream.yml — verify downstream repos don't depend on the removed payload fields before merging.

Important Files Changed

Filename	Overview
.github/workflows/notify-downstream.yml	Removes broken bash commit-message parsing, adds repository_dispatch trigger for forwarded events, correctly skips wait-for-ci on non-push triggers, and simplifies the dispatch payload. One non-blocking concern: removed payload fields (repo_name, short_sha, message, type) may silently break downstream consumers if not coordinated.

Sequence Diagram

sequenceDiagram
    participant UP as Upstream Repo
    participant MPP as meta_plugin_protocol
    participant DS as Downstream Repos<br/>(meta_cli, meta_git_cli, etc.)

    alt push to main
        MPP->>MPP: wait-for-ci (lewagon/wait-on-check-action)
        MPP->>DS: repository_dispatch(dependency-updated)<br/>payload: {repo, sha, actor}
    else repository_dispatch(dependency-updated) received
        UP->>MPP: repository_dispatch(dependency-updated)
        Note over MPP: skip wait-for-ci (if: github.event_name == 'push')
        MPP->>DS: repository_dispatch(dependency-updated)<br/>payload: {repo, sha (MPP HEAD), actor}
    end

Loading

Prompt To Fix All With AI

This is a comment left during a code review.
Path: .github/workflows/notify-downstream.yml
Line: 42-47

Comment:
**Breaking payload change for downstream consumers**

The PR removes `repo_name`, `short_sha`, `message`, and `type` from the dispatched payload. If any downstream workflow (e.g. in `meta_cli`, `meta_git_cli`, `meta_project_cli`, or `meta_rust_cli`) currently references `github.event.client_payload.type`, `.message`, `.short_sha`, or `.repo_name`, those expressions will silently resolve to `null`/empty without any dispatch failure.

Before merging, confirm that none of the downstream repos' `repository_dispatch`-triggered workflows use these removed fields. If they do, those workflows should be updated in the same change or in a coordinated follow-up to avoid silent failures.

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix: simplify notify-downstream workflow" | Re-trigger Greptile}

[greptile-apps]

Breaking payload change for downstream consumers

The PR removes repo_name, short_sha, message, and type from the dispatched payload. If any downstream workflow (e.g. in meta_cli, meta_git_cli, meta_project_cli, or meta_rust_cli) currently references github.event.client_payload.type, .message, .short_sha, or .repo_name, those expressions will silently resolve to null/empty without any dispatch failure.

Before merging, confirm that none of the downstream repos' repository_dispatch-triggered workflows use these removed fields. If they do, those workflows should be updated in the same change or in a coordinated follow-up to avoid silent failures.

Prompt To Fix With AI

This is a comment left during a code review.
Path: .github/workflows/notify-downstream.yml
Line: 42-47

Comment:
**Breaking payload change for downstream consumers**

The PR removes `repo_name`, `short_sha`, `message`, and `type` from the dispatched payload. If any downstream workflow (e.g. in `meta_cli`, `meta_git_cli`, `meta_project_cli`, or `meta_rust_cli`) currently references `github.event.client_payload.type`, `.message`, `.short_sha`, or `.repo_name`, those expressions will silently resolve to `null`/empty without any dispatch failure.

Before merging, confirm that none of the downstream repos' `repository_dispatch`-triggered workflows use these removed fields. If they do, those workflows should be updated in the same change or in a coordinated follow-up to avoid silent failures.

How can I resolve this? If you propose a fix, please make it concise.

[mateodelnorte]

Fixed — restored full payload, removed repository_dispatch trigger to prevent cascades, switched to heredoc output for safe commit message handling.