Skip to content

chore: Enhance security in base_dir replacement #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
genedna merged 1 commit into from
Aug 17, 2024
Merged

chore: Enhance security in base_dir replacement #518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions common/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,20 @@ impl Default for Config {
std::env::var("MEGA_BASE_DIR").unwrap_or_else(|_| "/tmp/.mega".to_string()),
);
std::fs::create_dir_all(&base_dir).unwrap();

// use mega/config.toml because mega use sqlite as default db
let default_config = include_str!("../../mega/config.toml");
let default_config = default_config.replace("/tmp/.mega", base_dir.to_str().unwrap());
let default_config = default_config
.lines()
.map(|line| {
if line.starts_with("base_dir ") {
format!("base_dir = \"{}\"", base_dir.to_str().unwrap())
} else {
line.to_string()
}
})
.collect::<Vec<String>>()
.join("\n");

let config_path = base_dir.join("config.toml");
std::fs::write(&config_path, default_config).unwrap();
Expand Down