Android Version

[housseindjirdeh]

Since this is built with React Native, it only makes sense to include an Android version.

Unfortunately, I haven't once tried running the application on a Android emulator or device so there is definitely going to be quite a bit that needs to be done to have it working smoothly across both platforms.

[rmevans9]

I love the look of this app but can't use it since I run Android... so I spent 5ish minutes to see if there is anything that is a major showstopper for this to run on Android. My findings:

• You need to hook up deep linking on Android. Add this to your main activity in AndroidManifest

<intent-filter>
    <action android:name="android.intent.action.VIEW" />
    <category android:name="android.intent.category.DEFAULT" />
    <category android:name="android.intent.category.BROWSABLE" />
    <data android:scheme="gitpoint" />
</intent-filter>

• react-native-search-bar is iOS only. Would need to either switch to something more cross platform or provide an Android alternative.

So far that is all i have as I haven't had a chance to work around the search bar issue. The screens I have seen working do look good on Android though so thumbs up there!

[housseindjirdeh]

@rmevans9 I can't thank you enough for this. I'm so happy to hear that screens are looking quite good on Android 🙌 . From the sounds of it, it doesn't look like there is too much to do 😃

I'm going to tackle this in the coming week and hopefully have it up and running in around a week or so. Will post my updates here (and of course: any kind of contribution is always welcome!!)

[rmevans9]

I should probably point out I only saw like two screens because if the second issue pointed out.

[housseindjirdeh]

Thank you, in that case you're right there are quite a few screens in the app so there may definitely be things to do in many of them (off the top of my head for example - I use ActionSheetIOS in a number of screens so will need to find a cross platform solution for that)

Two screens looking decent is still good news nevertheless! :)

[rmevans9]

After commenting out SearchBar in the 4 screen files I have the app up and working. I am sure that if I triggered anything that used ActionSheetIOS it would fail miserably.

[housseindjirdeh]

Sweet sweet sweeet.

All in all it doesn't look too bad and I'm so glad :D. The tab bar looks completely out of place for one and screens without the navbar (like the notification's screen) makes things look a bit off I think.

Going to spend some time later this week running it myself and see how many things I can spot and smooth out. Thanks again for all the help, and please don't hesitate to put up a PR for anything if you feel like. Already appreciate you putting one up so fast :)

[rmevans9]

The tab bar is because react-navigation defaults to TabBarTop for Android with a tabBarPosition of top. You just need to force it to the bottom and tell it to use TabBarBottom and set the position. Looking at your code you already force it to TabBarBottom so it is a simple change to force it to the bottom. PR landing in ~30 seconds

ref: https://reactnavigation.org/docs/navigators/tab#TabNavigatorConfig

[housseindjirdeh]

Cheers I had a feeling it was defaulted to the top for react-navigation, thank you :D

Don't forget to add yourself to the list of contributors in the README!

[rmevans9]

Alright - I think that is plenty productive for sitting in an airport. If you want or need further assistance just tag me here or if you just have a question you can find me hanging around the react-native channel in infinite red's OSS community slack - find the link in https://github.com/infinitered/reactotron readme. Can't wait to see this on the Google Play store!

[housseindjirdeh]

Can't thank you enough for everything you've already done - will definitely keep you in the loop as things progress here 🙌

[Talor-A]

@housseindjirdeh I can assist with running on Android, I actually have a cross-platform wrapper for ActionSheet that I'm using in my own app that I can shoot you a PR for.

[housseindjirdeh]

Thank you so much @Talor-A, any assistance would be extremely appreciated! And that's awesome - I was just planning to look for a cross-platform wrapper so I'm glad you already have one 🙌