Fix typo in jwt package - #1070
Merged
Merged
Conversation
amidam
commented
Mar 19, 2021
Contributor
* change JWTTokenContextKey to JWTContextKey
* revise errors as well as comments
Contributor
Author
|
fixes #1071 |
peterbourgon
requested changes
Mar 20, 2021
* revert the API identifier to its previous value
* add JWTTokenContextKey side by side of JWTContextKey for historical compatibility
Member
|
Can you please leave the old identifiers in place, and mark them as deprecated? |
added 2 commits
June 2, 2021 21:54
* define JWTContextKey as a new constant
* mark JWTTokenContextKey as a deprecated constant
* revise corresponding error messages
# Conflicts: # auth/jwt/middleware.go
Contributor
Author
I have done it already. I added a new constant called |
Contributor
Author
Still they both have the same value |
* define JWTContextKey as a new constant
* mark JWTTokenContextKey as a deprecated constant
* revise corresponding error messages
Contributor
Author
I have done it. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.