Skip to content

Change default file key string to caller - #439

Merged
peterbourgon merged 1 commit into
go-kit:masterfrom
willfaught:caller
Jan 17, 2017
Merged

Change default file key string to caller#439
peterbourgon merged 1 commit into
go-kit:masterfrom
willfaught:caller

Conversation

@willfaught

Copy link
Copy Markdown
Contributor

Fixes #432.

@willfaught

Copy link
Copy Markdown
Contributor Author

@peterbourgon Looks like TestGauge and TestCounter fail intermittently? Is there a way I can rerun the build?

@peterbourgon

peterbourgon commented Jan 17, 2017

Copy link
Copy Markdown
Member

It's not you, it's Circonus. They write their lib so it's basically impossible to test, and change its behavior so the hacks I use stop working. I'll fix it in master and maybe you can rebase? Sorry for the noise.

@willfaught

Copy link
Copy Markdown
Contributor Author

Rebased

@peterbourgon

Copy link
Copy Markdown
Member

Nice! Thanks!

@peterbourgon
peterbourgon merged commit 187650f into go-kit:master Jan 17, 2017
@willfaught
willfaught deleted the caller branch January 17, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants