Skip to content

use a TODO context - #857

Merged
peterbourgon merged 1 commit into
go-kit:masterfrom
smlrepo:master
Apr 16, 2019
Merged

use a TODO context#857
peterbourgon merged 1 commit into
go-kit:masterfrom
smlrepo:master

Conversation

@h8liu

@h8liu h8liu commented Apr 7, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@h8liu h8liu changed the title fix #856 use a TODO context Apr 7, 2019
@peterbourgon

Copy link
Copy Markdown
Member
=== RUN   TestSend
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x7f0865]

goroutine 11 [running]:
net/http.(*Request).WithContext(...)
	/usr/local/go/src/net/http/request.go:353
github.com/aws/aws-sdk-go-v2/aws.setRequestContext(...)
	/home/build/go/src/github.com/aws/aws-sdk-go-v2/aws/request_context.go:11

Doesn't work.

@h8liu

h8liu commented Apr 12, 2019

Copy link
Copy Markdown
Contributor Author

please take a look.

@h8liu

h8liu commented Apr 13, 2019

Copy link
Copy Markdown
Contributor Author

not sure why circleci failed this time.

@peterbourgon
peterbourgon merged commit 22a2d43 into go-kit:master Apr 16, 2019
@peterbourgon

Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants