fix cloudwatchiface api change - #874
Closed
h8liu wants to merge 1 commit into
Closed
Conversation
Contributor
|
B/c of aws/aws-sdk-go-v2#298 (When I wrote this package, I didn't realize the v2 sdk was going to be in so much flux.) |
nelz9999
approved these changes
May 26, 2019
nelz9999
suggested changes
May 26, 2019
nelz9999
left a comment
Contributor
There was a problem hiding this comment.
Build is failing... Probably need to update the unit test too.
Member
|
This was fixed elsewhere. |
Contributor
|
Not quite, this is a different issue. @peterbourgon I believe you're referencing #856. This issue is new as of 3 days ago. |
Member
|
Oh fuck, did they change this shit again? |
Member
|
Member
|
@h8liu Can you please update the test? |
Member
|
OK, now it was fixed elsewhere: #878. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.