Repository navigation
[shaping] add Advance; deprecate some other fields - #219
Merged
Merged
Conversation
benoitkugler
requested review from
andydotxyz and
whereswaldon
as code owners
January 20, 2026 13:47
whereswaldon
approved these changes
Jan 20, 2026
whereswaldon
left a comment
Member
There was a problem hiding this comment.
Thank you! I look forward to the savings this will enable.
Contributor
Author
|
@andydotxyz Any chance you could have a look at these changes? It would be nice to publish them and start updating users codebases. |
andydotxyz
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the transition path discussed in #210.
I've tried and make the minimal changes so that tests pass. As proposed, this PR
Glyph.TextIndex() int,Glyph.RunesCount() int,Glyph.GlyphsCount() intGlyph.AdvanceXAdvance,YAdvance,ClusterIndex,RuneCount,GlyphCountfields