Repository navigation
build(release): keep the sub-module pins at the last released tag between releases - #590
Merged
Merged
Conversation
…ween releases Moving middleware/*/go.mod to v1.6.0 before that tag exists broke every consumer that pins a sub-module at a pseudo-version: go.mod resolution needs the required root version to exist, and probatorium's observability refapp (metrics + otel at celeris main) failed to repin within the hour. CheckRelease's consistency mode (CI, VERSION unset) now requires the pins to agree with each other and to be Version or older; release mode (VERSION set) still requires every stamp to equal the tag, so PrepRelease runs in the final PR before the release and nowhere else. Pins back to 1.5.8; Version and the README stay at 1.6.0. Controls: consistency passes at 1.5.8, release mode fails at 1.5.8, a half-moved pin set fails, pins newer than Version fail, and PrepRelease followed by release mode passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#582 moved
middleware/*/go.modtoceleris v1.6.0before that tag exists. That breaks any consumer that pins a sub-module at a pseudo-version, because module resolution needs the required root version to exist: probatorium's observability refapp (metrics + otel pinned at celerismain) failed to repin within the hour (reading github.com/goceleris/celeris/go.mod at revision v1.6.0: unknown revision).Change: pins back to 1.5.8 (the last release).
mage CheckReleasein consistency mode (CI, noVERSION) now requires the four pins to agree with each other and to beVersionor older; release mode (VERSIONset, what the Release workflow runs) still requires every stamp to equal the tag. SoPrepReleaseruns in the final PR before the release, and GOVERNANCE.md says so.Versionand the README heading stay at 1.6.0.Controls run locally: consistency at 1.5.8 → pass; release mode at 1.5.8 → fail; one pin moved (half-done prep) → fail; all pins newer than Version → fail;
PrepReleasethen release mode → pass (and consistency mode still passes afterwards).