build(release): stamp gate + workflow-created tags; fallbackVersion to 1.4.13 - #79
Merged
Merged
Conversation
… to 1.4.13 fallbackVersion sat at 1.4.11 two releases after v1.4.13 shipped: it is what a (devel) or test build reports, and what probatorium records for such a build, and nothing checked it. scripts/check-release-stamps.sh verifies that fallbackVersion and the README's download TAG agree with the given version, or with each other when none is given. CI runs the second form on every PR. The Release workflow gains a workflow_dispatch input: from main it runs the check against the requested version, verifies and tests the module, and only then creates the tag and the GitHub Release itself, then attaches the binaries and pings the proxy from the same run. A release created by hand still goes through the same gate and stops before the binaries and the proxy ping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of goceleris/celeris#582 for loadgen.
scripts/check-release-stamps.sh [vX.Y.Z]:fallbackVersion(what a(devel)/test build reports and what probatorium records for it) and the README downloadTAGmust agree with the argument, or with each other when none is given. Runs in CI on every PR.release.ymlgainsworkflow_dispatchwith aversioninput: frommainit runs the check against the input,go mod verify/build/vet/test, then creates the tag and the GitHub Release itself; the binaries (with provenance) and the proxy ping run from the same run. A hand-made release still runs the gate first and stops before the binaries and the proxy.fallbackVersion1.4.11 → 1.4.13 (the current release; it had been stale since v1.4.12).Verified locally: the stale tree fails the script naming the mismatch; after the bump it passes; an explicit non-matching version fails;
actionlintclean.