ci: run govulncheck on both modules - #82
Merged
Merged
Conversation
Only celeris ran govulncheck. loadgen is a published module and its testserver helper pins its own celeris, so both are scanned. govulncheck fails only when this code can reach a vulnerable symbol. The scanner is pinned to v1.8.0; the vulnerability database is fetched live on every run.
This was referenced Sep 19, 2026
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
Vulnerability Checkjob that runsgovulncheck ./...on both Go modules: the root module andinternal/integrationtest/testserver, which pins its own celeris. Until now only celeris ran govulncheck.Refs goceleris/celeris#426. The docs half of that issue is already done: docs has Dependabot for bun and GitHub Actions, and an
astro checkgate. The probatorium half follows after goceleris/probatorium#400.Details
golang.org/x/vuln/cmd/govulncheck@v1.8.0, the current release, instead of@latest. A new scanner therefore cannot change the verdict unannounced. The vulnerability database is fetched live from vuln.go.dev on every run.Proof that the job can fail
The job's two
runsteps were extracted verbatim from thisci.ymlwith PyYAML and run withbash --noprofile --norc -eo pipefailin each step's working directory, using govulncheck v1.8.0, against three copies of the tree:jwt.MapClaims.VerifyAudience(github.com/dgrijalva/jwt-go v3.2.0, GO-2020-0017, no fixed version)So each step catches a reachable vulnerability in its own module, and passes on the unedited tree. CI on this PR shows the unedited result on the runner.
At main (ea3c3b9), both modules scan clean: "No vulnerabilities found."