Skip to content
This repository was archived by the owner on Mar 22, 2024. It is now read-only.

afl-clang-fast: remove useless codes related to maybe_linking - #83

Merged
lszekeres merged 1 commit into
google:masterfrom
QinlinChen:fixbug
Apr 9, 2020
Merged

lszekeres merged 1 commit into
google:masterfrom
QinlinChen:fixbug

Conversation

@QinlinChen

Copy link
Copy Markdown
Contributor

Now that the maybe_linking check is removed in afl-clang-fast.c, maybe it is better to remove useless codes caused by it since maybe_linking is now defined but not used.

I think in the old code, "maybe_linking" should not be set to zero on seeing the "-shared" argument because dynamic libraries should also statically link the AFL runtime into themselves. But now that the maybe_linking variable is removed, it is no more a problem.

Besides, the code 'if (argc == 1 && !strcmp(argv[1], "-v")) maybe_linking = 0;' in line 146 itself is useless regardless of the maybe_linking variable because in main() we have check "if argc < 2, then exit".

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@QinlinChen

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@lszekeres

Copy link
Copy Markdown
Member

Just linking the PR that removed the usage of maybe_linking for reference: #80

@lszekeres lszekeres left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanmetzman jonathanmetzman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll merge this when I'm not OOO next week if someone else doesn't first.

@lszekeres
lszekeres merged commit f2e44af into google:master Apr 9, 2020
sthagen added a commit to sthagen/google-AFL that referenced this pull request Apr 9, 2020
afl-clang-fast: remove unused code related to maybe_linking (google#83)
@QinlinChen
QinlinChen deleted the fixbug branch April 9, 2020 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants