You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue tracks follow-up improvements identified during the review of PR #608. We need to address the following technical debt and testing improvements:
Handle nested data structures: Ensure that the parametersWithParameters function safely drops key parameters that contain values like a nested array.
Standardize UIDevice mocking: Fix the tests that are swizzling UIDevice to "Not Do That," or ensure all tests are doing it the same way. Relying on the real UIDevice will make tests non-hermetic.
Uplevel tests to the public API: Consider upleveling the new GIDEMMSupport unit tests to test against the public API instead of testing internal classes in isolation.
This issue tracks follow-up improvements identified during the review of PR #608. We need to address the following technical debt and testing improvements:
parametersWithParametersfunction safely drops key parameters that contain values like a nested array.UIDevicemocking: Fix the tests that are swizzlingUIDeviceto "Not Do That," or ensure all tests are doing it the same way. Relying on the realUIDevicewill make tests non-hermetic.GIDEMMSupportunit tests to test against the public API instead of testing internal classes in isolation.