Skip to content

Refactor and improve GIDEMMSupport parameters and tests #611

Description

@AkshatG6

This issue tracks follow-up improvements identified during the review of PR #608. We need to address the following technical debt and testing improvements:

  • Handle nested data structures: Ensure that the parametersWithParameters function safely drops key parameters that contain values like a nested array.
  • Standardize UIDevice mocking: Fix the tests that are swizzling UIDevice to "Not Do That," or ensure all tests are doing it the same way. Relying on the real UIDevice will make tests non-hermetic.
  • Uplevel tests to the public API: Consider upleveling the new GIDEMMSupport unit tests to test against the public API instead of testing internal classes in isolation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesttriageIssues that need to be triaged

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions