Proxy --acpi-table, --device-tree-overlay, and --file-backed-mapping to crosvm run - #2960
Open
erjiaqing wants to merge 1 commit into
Open
Proxy --acpi-table, --device-tree-overlay, and --file-backed-mapping to crosvm run#2960erjiaqing wants to merge 1 commit into
erjiaqing wants to merge 1 commit into
Conversation
…to crosvm run Introduce new gflags and cuttlefish config properties to allow proxying user provided ACPI tables, device tree overlays, and file-backed mappings to crosvm run command. These options are passed when starting the main crosvm runner command. Assisted-by: Antigravity:Gemini-Next TAG=agy CONV=2a93473d-f5c9-4f0d-89a1-b07cb069a790
Databean
reviewed
Aug 6, 2026
Comment on lines
+625
to
+626
| std::vector<std::string> crosvm_file_backed_mapping_vec = | ||
| CF_EXPECT(GET_FLAG_STR_VALUE(crosvm_file_backed_mapping)); |
Member
There was a problem hiding this comment.
The suggested arguments of addr=NUM,size=NUM,path=PATH,offset=NUM,rw,sync,align,ram will interact badly with GET_FLAG_STR_VALUE, which separates arguments to different by splitting on commas.
Specifically,
cvd create --crosvm_file_backed_mapping=addr=NUM,size=NUM --num_instances=2
will result in two invocations of crosvm:
$ crosvm --file-backed-mapping=addr=NUM
$ crosvm --file-backed-mapping=size=NUM
which I assume is not the intended behavior.
The easy option is to put this in CuttlefishConfig rather than CuttlefishConfig::InstanceSpecific and declare that all instances launched concurrently must use the same value.
Another route we've gone is e.g. extra_bootconfig_args_base64 which expects the arguments to be base64-encoded so that GET_FLAG_STR_VALUE can correctly divide the arguments between instances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL Introduce new command line arguments and cuttlefish config properties to allow proxying user provided ACPI tables, device tree overlays, and file-backed mappings to
crosvm runcommand.Assisted-by: Antigravity:Gemini-Next
Bug: 510177847