tools: baseimage: Add pre-flight existence checks - #2968
Open
rmuthiah wants to merge 1 commit into
Open
Conversation
rmuthiah
enabled auto-merge
August 4, 2026 23:35
3405691582
reviewed
Aug 5, 2026
3405691582
left a comment
Collaborator
There was a problem hiding this comment.
Throughout: coalesce the if err != nil {} if exists {} pattern into just returning err != nil || exists or similar. Not really useful to have separate branches here.
ser-io
requested changes
Aug 5, 2026
rmuthiah
force-pushed
the
fail-fast
branch
2 times, most recently
from
August 5, 2026 21:35
69a9c6c to
25c61ba
Compare
ser-io
approved these changes
Aug 5, 2026
rmuthiah
force-pushed
the
fail-fast
branch
2 times, most recently
from
August 5, 2026 21:56
6dbfb75 to
0e7cf82
Compare
…builder resources Add pre-flight existence verification before starting image creation builds in create_gce_base_image and create_gce_fixed_kernel: - Check that required source images exist in their respective projects before beginning. - Check that the target image-name does not already exist in the target project. - In GceHelper.BuildImage, check that builder attached disks do not already exist before attempting resource creation. Assisted-by: Antigravity:Gemini-Next
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 6, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for GCE images and builder resources
Add pre-flight existence verification before starting image creation builds in create_gce_base_image and create_gce_fixed_kernel:
Assisted-by: Antrigravity:Gemini-Next