Package etc/cvd_config in /usr/lib/cuttlefish-common - #2969
Merged
Conversation
jemoreira
approved these changes
Aug 4, 2026
Databean
force-pushed
the
package_cvd_config
branch
from
August 5, 2026 00:09
3e16272 to
cce136a
Compare
Databean
enabled auto-merge
August 5, 2026 00:09
Databean
force-pushed
the
package_cvd_config
branch
from
August 5, 2026 07:17
cce136a to
94afab6
Compare
Databean
force-pushed
the
package_cvd_config
branch
from
August 5, 2026 22:03
94afab6 to
2f324c0
Compare
Member
Author
|
Had to update the e2etests since they make assumptions about the display size of phone devices. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 6, 2026
Databean
force-pushed
the
package_cvd_config
branch
from
August 6, 2026 16:33
2f324c0 to
9fe5ed2
Compare
Databean
enabled auto-merge
August 6, 2026 16:33
Databean
force-pushed
the
package_cvd_config
branch
from
August 7, 2026 22:11
9fe5ed2 to
7f2a37a
Compare
These files are included in `cvd-host_package.tar.gz` as `etc/cvd_config/*`. `assemble_cvd` uses these files. Running in `--host_substitution=only` mode produces this warning: ``` /var/tmp/cvd/270178/1785454400023677/artifacts/0/android-info.txt contains invalid config preset: 'phone'. Config 'phone' not found: 1. config_flag.cpp:83 | ReadConfig | Could not read config file "/var/tmp/cvd/270178/1785454400023677/artifacts/host_tools/etc/cvd_config/cvd_config_phone.json" | cuttlefish/common/libs/utils/files.cpp:331 | Result<std::string> cuttlefish::ReadFileContents(const std::string &) v CF_EXPECT(FileExists(filepath)) The file at "/var/tmp/cvd/270178/1785454400023677/artifacts/host_tools/etc/cvd_config/cvd_config_phone.json" does not exist. ``` These files are based on android17-release on android.googlesource.com, the most recently published version plus ag/41193528 and ag/41193529 which modify config_phone.json. Bug: b/542721218
Bug: b/542721218
Databean
force-pushed
the
package_cvd_config
branch
from
August 8, 2026 00:23
7f2a37a to
b10143d
Compare
Databean
enabled auto-merge
August 8, 2026 00:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These files are included in
cvd-host_package.tar.gzasetc/cvd_config/*.assemble_cvduses these files. Running in--host_substitution=onlymode produces this warning:These files are based on android17-release on android.googlesource.com, the most recently published version plus ag/41193528 and ag/41193529 which modify config_phone.json.
Bug: b/542721218