Skip to content

feat(cvd): Inject netsim_args as environment variables into netsimd - #2973

Merged
rmuthiah merged 1 commit into
google:mainfrom
rmuthiah:netsim-args-filter
Aug 8, 2026
Merged

feat(cvd): Inject netsim_args as environment variables into netsimd#2973
rmuthiah merged 1 commit into
google:mainfrom
rmuthiah:netsim-args-filter

Conversation

@rmuthiah

@rmuthiah rmuthiah commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator
  • Extract NETSIM_NO_WEB_SERVER and NETSIM_GRPC_PORT from passthrough netsim_args and inject them directly as environment variables into netsimd.
  • Combine all remaining netsim_args into a single space-separated string and inject as the NETSIM_ARGS environment variable.

TAG=agy
CONV=7e6b7c86-e570-4900-a8f4-683776c7dc60
Assisted-by: Jetski:GeminiNext

@rmuthiah
rmuthiah force-pushed the netsim-args-filter branch from 53a04a0 to 3830c5e Compare August 5, 2026 01:52
@rmuthiah
rmuthiah enabled auto-merge August 5, 2026 22:37
Databean
Databean approved these changes Aug 5, 2026
View reviewed changes
Comment thread base/cvd/cuttlefish/host/commands/run_cvd/launch/netsim_server.cpp Outdated
Comment thread base/cvd/cuttlefish/host/commands/run_cvd/launch/netsim_server.cpp Outdated
@rmuthiah
rmuthiah force-pushed the netsim-args-filter branch 3 times, most recently from e6a2c41 to a8d420e Compare August 6, 2026 01:32
@rmuthiah rmuthiah added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Aug 6, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Aug 6, 2026
@rmuthiah
rmuthiah force-pushed the netsim-args-filter branch from a8d420e to fb74c3d Compare August 6, 2026 16:57
@rmuthiah
feat(cvd): Inject NETSIM_GRPC_PORT as environment variable into netsimd
ed5c7e8 
TAG=agy
CONV=7e6b7c86-e570-4900-a8f4-683776c7dc60
Assisted-by: Jetski:GeminiNext
@rmuthiah
rmuthiah force-pushed the netsim-args-filter branch from fb74c3d to ed5c7e8 Compare August 7, 2026 21:12
@rmuthiah rmuthiah added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Aug 7, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Aug 7, 2026
@rmuthiah
rmuthiah added this pull request to the merge queue Aug 7, 2026
Merged via the queue into google:main with commit ab62bad Aug 8, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Databean Databean Databean approved these changes
@AlpineOolong AlpineOolong AlpineOolong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rmuthiah @Databean @AlpineOolong @GoogleCuttlefishTesterBot