Add a base_dir attribute for the package_files rule - #2978
Merged
Conversation
Databean
force-pushed
the
package_base_dir
branch
from
August 6, 2026 18:13
774d579 to
1a2379c
Compare
jmacnak
approved these changes
Aug 6, 2026
Member
Author
|
Thanks for reviewing! |
Databean
enabled auto-merge
August 6, 2026 20:56
Databean
disabled auto-merge
August 7, 2026 01:05
Databean
enabled auto-merge
August 7, 2026 01:05
In practice all members of a package_rule were in the same directory. This makes it explicit and reduces some duplication in the `package_file_symlink_to_package_file` and `package_file_to_src` attributes. Bug: b/429012834
Created `:cvd` alias for convenience. Bug: b/429012834
Databean
force-pushed
the
package_base_dir
branch
from
August 7, 2026 17:36
3d30037 to
2ebe7a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In practice all members of a package_rule were in the same directory. This makes it explicit and reduces some duplication in the
package_file_symlink_to_package_fileandpackage_file_to_srcattributes.Bug: b/429012834