Hedvig Letters Sans: Version 1.001; ttfautohint (v1.8.4.16-eb64) added - #10844
Open
emmamarichal wants to merge 2 commits into
Open
Hedvig Letters Sans: Version 1.001; ttfautohint (v1.8.4.16-eb64) added
#10844emmamarichal wants to merge 2 commits into
emmamarichal wants to merge 2 commits into
Conversation
Taken from the upstream repo https://github.com/KanonFoundry/HedvigLetters at commit KanonFoundry/HedvigLetters@d05ac77.
Contributor
FontSpector reportfontspector version: 1.7.4 Check results[2] ofl/hedvigletterssans/METADATA.pb
|
| Message | Languages |
|---|---|
| Auxiliary orthography codepoints: | * da_Latn (Danish) |
| The following auxiliary characters are missing from the font: Ǿ | |
| The following auxiliary characters are missing from the font: ǿ | |
| Auxiliary orthography codepoints: | * de_Latn (German) |
| The following auxiliary characters are missing from the font: Ĕ | |
| The following auxiliary characters are missing from the font: Ĭ | |
| The following auxiliary characters are missing from the font: Ŏ | |
| The following auxiliary characters are missing from the font: ĕ | |
| The following auxiliary characters are missing from the font: ĭ | |
| The following auxiliary characters are missing from the font: ŏ | |
| The following auxiliary characters are missing from the font: ſ | |
| Auxiliary orthography codepoints: | * nb_Latn (Norwegian Bokmål) |
| The following auxiliary characters are missing from the font: Ǎ | |
| The following auxiliary characters are missing from the font: Ŧ | |
| The following auxiliary characters are missing from the font: ǎ | |
| The following auxiliary characters are missing from the font: ŧ | |
| Auxiliary orthography codepoints: | * en_Latn (English) |
| The following auxiliary characters are missing from the font: Ĕ | |
| The following auxiliary characters are missing from the font: Ĭ | |
| The following auxiliary characters are missing from the font: Ŏ | |
| The following auxiliary characters are missing from the font: ĕ | |
| The following auxiliary characters are missing from the font: ĭ | |
| The following auxiliary characters are missing from the font: ŏ | |
| The following auxiliary characters are missing from the font: ʻ | |
| Auxiliary orthography codepoints: | * lt_Latn (Lithuanian) |
| The following auxiliary characters are missing from the font: Ẽ | |
| The following auxiliary characters are missing from the font: ẽ | |
| Auxiliary orthography codepoints: | * cs_Latn (Czech) |
| The following auxiliary characters are missing from the font: Ĕ | * cy_Latn (Welsh) |
| The following auxiliary characters are missing from the font: Ĭ | * es_Latn (Spanish) |
| The following auxiliary characters are missing from the font: Ŏ | * hu_Latn (Hungarian) |
| The following auxiliary characters are missing from the font: ĕ | * pt_Latn (Portuguese) |
| The following auxiliary characters are missing from the font: ĭ | * sk_Latn (Slovak) |
| The following auxiliary characters are missing from the font: ŏ | * tr_Latn (Turkish) |
| Auxiliary orthography codepoints: | * ca_Latn (Catalan) |
| The following auxiliary characters are missing from the font: Ĕ | |
| The following auxiliary characters are missing from the font: Ĭ | |
| The following auxiliary characters are missing from the font: Ŀ | |
| The following auxiliary characters are missing from the font: Ŏ | |
| The following auxiliary characters are missing from the font: ĕ | |
| The following auxiliary characters are missing from the font: ĭ | |
| The following auxiliary characters are missing from the font: ŀ | |
| The following auxiliary characters are missing from the font: ŏ | |
| Auxiliary orthography codepoints: | * fr_Latn (French) |
| The following auxiliary characters are missing from the font: Ǔ | |
| The following auxiliary characters are missing from the font: ſ | |
| The following auxiliary characters are missing from the font: ǔ | |
| Auxiliary orthography codepoints: | * fi_Latn (Finnish) |
| The following auxiliary characters are missing from the font: Ǧ | |
| The following auxiliary characters are missing from the font: Ǥ | |
| The following auxiliary characters are missing from the font: Ȟ | |
| The following auxiliary characters are missing from the font: Ǩ | |
| The following auxiliary characters are missing from the font: Ŧ | |
| The following auxiliary characters are missing from the font: Ʒ | |
| The following auxiliary characters are missing from the font: Ǯ | |
| The following auxiliary characters are missing from the font: ǧ | |
| The following auxiliary characters are missing from the font: ǥ | |
| The following auxiliary characters are missing from the font: ȟ | |
| The following auxiliary characters are missing from the font: ǩ | |
| The following auxiliary characters are missing from the font: ŧ | |
| The following auxiliary characters are missing from the font: ʒ | |
| The following auxiliary characters are missing from the font: ǯ |
⚠️ WARN Ensure dotted circle glyph is present and can attach marks. (dotted_circle)
⚠️ WARN No dotted circle glyph present [code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that
replace the dot. (soft_dotted)
⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings:
-
į́
-
į̂
-
į̌
-
į̄
-
į̀
-
į̃The dot of soft dotted characters should disappear in other cases, for example:
-
į̈
-
į̇
-
į̊
-
į̆
-
į̋
-
į̒ [code: soft-dotted]
⚠️ WARN Are there any misaligned on-curve points? (outline_alignment_miss)
⚠️ WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
-
- Oslash (U+00D8): X=463,Y=701 (should be at cap-height 700?)
-
- Q (U+0051): X=563,Y=-1.5 (should be at baseline 0?)
-
- amacron (U+0101): X=122,Y=701 (should be at cap-height 700?)
-
- amacron (U+0101): X=400,Y=701 (should be at cap-height 700?)
-
- aring (U+00E5): X=293.5,Y=699 (should be at cap-height 700?)
-
- aring (U+00E5): X=229.5,Y=699 (should be at cap-height 700?)
-
- emacron (U+0113): X=142,Y=701 (should be at cap-height 700?)
-
- emacron (U+0113): X=420,Y=701 (should be at cap-height 700?)
-
- uni1E21 (U+1E21): X=148,Y=701 (should be at cap-height 700?)
... and 30 others [code: found-misalignments]
- uni1E21 (U+1E21): X=148,Y=701 (should be at cap-height 700?)
⚠️ WARN Are any segments inordinately short? (outline_short_segments)
⚠️ WARN The following glyphs have short segments:
- Eng (U+014A) contains a short segment Quad(QuadBez { p0: (550.5, -173.0), p1: (565.0, -169.0), p2: (571.5, -153.5) }) (length: 29.74, total outline: 4995.98)
- uni0162 (U+0162) contains a short segment Line(Line { p0: (277.0, -70.0), p1: (285.0, -70.0) }) (length: 8.00, total outline: 3341.37)
- uni0162.alt contains a short segment Line(Line { p0: (277.0, -70.0), p1: (285.0, -70.0) }) (length: 8.00, total outline: 3341.37)
- germandbls (U+00DF) contains a short segment Line(Line { p0: (117.0, 520.0), p1: (117.0, 534.0) }) (length: 14.00, total outline: 4227.99)
- f_f_i contains a short segment Quad(QuadBez { p0: (235.0, 626.0), p1: (220.0, 622.0), p2: (213.5, 606.5) }) (length: 30.15, total outline: 5466.07)
- f_f_i contains a short segment Quad(QuadBez { p0: (516.0, 626.0), p1: (501.0, 622.0), p2: (494.5, 606.5) }) (length: 30.15, total outline: 5466.07)
- six (U+0036) contains a short segment Line(Line { p0: (441.0, 523.0), p1: (441.0, 533.0) }) (length: 10.00, total outline: 2886.51)
- nine (U+0039) contains a short segment Line(Line { p0: (149.0, 177.0), p1: (149.0, 167.0) }) (length: 10.00, total outline: 2877.54)
- at (U+0040) contains a short segment Quad(QuadBez { p0: (666.0, 150.0), p1: (666.0, 128.0), p2: (678.0, 115.5) }) (length: 37.47, total outline: 7257.88)
... and 1 others [code: found-short-segments]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
- ℹ️ INFO The family name "Hedvig Letters Sans" seems to be already in use.
Please visit http://namecheck.fontdata.com/ for more info. [code: name-collision]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| HedvigLettersSans-Regular.ttf | |
|---|---|
| Dehinted Size | 61928 |
| Hinted Size | 80828 |
| Increase | 18900 |
| Change | 30.5 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
cvt
fpgm
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.001; ttfautohint (v1.8.4.16-eb64) [code: version-not-detected]
[7] ofl/hedvigletterssans
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field. (googlefonts/metadata/consistent_repo_urls)
- 🔥 FAIL Repository URL is https://github.com/KanonFoundry/HedvigLetters. But:
- HTML description has 'href="https://github.com/KanonFoundry/HedvigLetters">github.com/KanonFoundry/HedvigLetters.' [code: mismatch]
🔥 FAIL Tofu should not be shown in sample texts. (googlefonts/tofu)
- 🔥 FAIL We detected support for the Amarakaeri language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the specimen 16 sample text (This suggests there's something wrong with the sample text):
- ̱ (U+0331) [code: bad-sample-text]
- 🔥 FAIL We detected support for the Qʼeqchiʼ language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the specimen 16 sample text (This suggests there's something wrong with the sample text):
- ʼ (U+02BC) [code: bad-sample-text]
- 🔥 FAIL We detected support for the Otomi, Mezquital language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the specimen 16 sample text (This suggests there's something wrong with the sample text):
- ̱ (U+0331) [code: bad-sample-text]
- 🔥 FAIL We detected support for the Secoya language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the specimen 16 sample text (This suggests there's something wrong with the sample text):
- ̱ (U+0331) [code: bad-sample-text]
- 🔥 FAIL We detected support for the Yapese language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the specimen 16 sample text (This suggests there's something wrong with the sample text):
- ʼ (U+02BC) [code: bad-sample-text]
- 🔥 FAIL We detected support for the Yucateco language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the specimen 16 sample text (This suggests there's something wrong with the sample text):
- ʼ (U+02BC) [code: bad-sample-text]
⚠️ WARN Ensure Fonts have 'ital' STAT axis. (opentype/STAT/ital_axis)
⚠️ WARN Static font is missing the 'STAT' table. [code: no-stat-table]
⚠️ WARN Check for codepoints not covered by METADATA subsets. (googlefonts/metadata/unreachable_subsetting)
⚠️ WARN ofl/hedvigletterssans/HedvigLettersSans-Regular.ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
- U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
- U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
- U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
- U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
- U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
- U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
- U+030C COMBINING CARON: try adding one of: tai-le, cherokee
- U+2021 DOUBLE DAGGER: try adding adlam
- U+2030 PER MILLE SIGN: try adding adlam
Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, math, menu, symbols [code: unreachable-subsetting]
ℹ️ INFO METADATA.pb subsets are correct? (googlefonts/metadata/subsets_correct)
-
ℹ️ INFO The subset 'math' is listed in production metadata, but only 0.05% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]
-
ℹ️ INFO The subset 'symbols' is listed in production metadata, but only 0.02% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]
-
ℹ️ INFO The subset 'latin-ext' is listed in production metadata, but only 0.12% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file (googlefonts/description/has_article)
- ℹ️ INFO This font doesn't have an ARTICLE.en_us.html file. [code: missing-article]
ℹ️ INFO Check axis ordering on the STAT table. (googlefonts/STAT/axis_order)
- ℹ️ INFO All of the fonts lack a STAT table. [code: summary]
Summary
| 🔥 FAIL | ℹ️ INFO | ✅ PASS | ⏩ SKIP | |
|---|---|---|---|---|
| 8 | 15 | 12 | 130 | 63 |
| 4% | 7% | 5% | 57% | 28% |
Contributor
FontSpector reportfontspector version: 1.7.4 Check results[7] ofl/hedvigletterssans🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field. (googlefonts/metadata/consistent_repo_urls)
🔥 FAIL Tofu should not be shown in sample texts. (googlefonts/tofu)
|
| Message | Languages |
|---|---|
| Auxiliary orthography codepoints: | * cs_Latn (Czech) |
| The following auxiliary characters are missing from the font: Ĕ | * cy_Latn (Welsh) |
| The following auxiliary characters are missing from the font: Ĭ | * es_Latn (Spanish) |
| The following auxiliary characters are missing from the font: Ŏ | * hu_Latn (Hungarian) |
| The following auxiliary characters are missing from the font: ĕ | * pt_Latn (Portuguese) |
| The following auxiliary characters are missing from the font: ĭ | * sk_Latn (Slovak) |
| The following auxiliary characters are missing from the font: ŏ | * tr_Latn (Turkish) |
| Auxiliary orthography codepoints: | * nb_Latn (Norwegian Bokmål) |
| The following auxiliary characters are missing from the font: Ǎ | |
| The following auxiliary characters are missing from the font: Ŧ | |
| The following auxiliary characters are missing from the font: ǎ | |
| The following auxiliary characters are missing from the font: ŧ | |
| Auxiliary orthography codepoints: | * fr_Latn (French) |
| The following auxiliary characters are missing from the font: Ǔ | |
| The following auxiliary characters are missing from the font: ſ | |
| The following auxiliary characters are missing from the font: ǔ | |
| Auxiliary orthography codepoints: | * de_Latn (German) |
| The following auxiliary characters are missing from the font: Ĕ | |
| The following auxiliary characters are missing from the font: Ĭ | |
| The following auxiliary characters are missing from the font: Ŏ | |
| The following auxiliary characters are missing from the font: ĕ | |
| The following auxiliary characters are missing from the font: ĭ | |
| The following auxiliary characters are missing from the font: ŏ | |
| The following auxiliary characters are missing from the font: ſ | |
| Auxiliary orthography codepoints: | * lt_Latn (Lithuanian) |
| The following auxiliary characters are missing from the font: Ẽ | |
| The following auxiliary characters are missing from the font: ẽ | |
| Auxiliary orthography codepoints: | * fi_Latn (Finnish) |
| The following auxiliary characters are missing from the font: Ǧ | |
| The following auxiliary characters are missing from the font: Ǥ | |
| The following auxiliary characters are missing from the font: Ȟ | |
| The following auxiliary characters are missing from the font: Ǩ | |
| The following auxiliary characters are missing from the font: Ŧ | |
| The following auxiliary characters are missing from the font: Ʒ | |
| The following auxiliary characters are missing from the font: Ǯ | |
| The following auxiliary characters are missing from the font: ǧ | |
| The following auxiliary characters are missing from the font: ǥ | |
| The following auxiliary characters are missing from the font: ȟ | |
| The following auxiliary characters are missing from the font: ǩ | |
| The following auxiliary characters are missing from the font: ŧ | |
| The following auxiliary characters are missing from the font: ʒ | |
| The following auxiliary characters are missing from the font: ǯ | |
| Auxiliary orthography codepoints: | * ca_Latn (Catalan) |
| The following auxiliary characters are missing from the font: Ĕ | |
| The following auxiliary characters are missing from the font: Ĭ | |
| The following auxiliary characters are missing from the font: Ŀ | |
| The following auxiliary characters are missing from the font: Ŏ | |
| The following auxiliary characters are missing from the font: ĕ | |
| The following auxiliary characters are missing from the font: ĭ | |
| The following auxiliary characters are missing from the font: ŀ | |
| The following auxiliary characters are missing from the font: ŏ | |
| Auxiliary orthography codepoints: | * da_Latn (Danish) |
| The following auxiliary characters are missing from the font: Ǿ | |
| The following auxiliary characters are missing from the font: ǿ | |
| Auxiliary orthography codepoints: | * en_Latn (English) |
| The following auxiliary characters are missing from the font: Ĕ | |
| The following auxiliary characters are missing from the font: Ĭ | |
| The following auxiliary characters are missing from the font: Ŏ | |
| The following auxiliary characters are missing from the font: ĕ | |
| The following auxiliary characters are missing from the font: ĭ | |
| The following auxiliary characters are missing from the font: ŏ | |
| The following auxiliary characters are missing from the font: ʻ |
⚠️ WARN Ensure dotted circle glyph is present and can attach marks. (dotted_circle)
⚠️ WARN No dotted circle glyph present [code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that
replace the dot. (soft_dotted)
⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings:
-
į́
-
į̀
-
į̌
-
į̃
-
į̄
-
į̂The dot of soft dotted characters should disappear in other cases, for example:
-
į̋
-
į̒
-
į̈
-
į̇
-
į̆
-
į̊ [code: soft-dotted]
⚠️ WARN Are there any misaligned on-curve points? (outline_alignment_miss)
⚠️ WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
-
- Oslash (U+00D8): X=463,Y=701 (should be at cap-height 700?)
-
- Q (U+0051): X=563,Y=-1.5 (should be at baseline 0?)
-
- amacron (U+0101): X=122,Y=701 (should be at cap-height 700?)
-
- amacron (U+0101): X=400,Y=701 (should be at cap-height 700?)
-
- aring (U+00E5): X=293.5,Y=699 (should be at cap-height 700?)
-
- aring (U+00E5): X=229.5,Y=699 (should be at cap-height 700?)
-
- emacron (U+0113): X=142,Y=701 (should be at cap-height 700?)
-
- emacron (U+0113): X=420,Y=701 (should be at cap-height 700?)
-
- uni1E21 (U+1E21): X=148,Y=701 (should be at cap-height 700?)
... and 30 others [code: found-misalignments]
- uni1E21 (U+1E21): X=148,Y=701 (should be at cap-height 700?)
⚠️ WARN Are any segments inordinately short? (outline_short_segments)
⚠️ WARN The following glyphs have short segments:
- Eng (U+014A) contains a short segment Quad(QuadBez { p0: (550.5, -173.0), p1: (565.0, -169.0), p2: (571.5, -153.5) }) (length: 29.74, total outline: 4995.98)
- uni0162 (U+0162) contains a short segment Line(Line { p0: (277.0, -70.0), p1: (285.0, -70.0) }) (length: 8.00, total outline: 3341.37)
- uni0162.alt contains a short segment Line(Line { p0: (277.0, -70.0), p1: (285.0, -70.0) }) (length: 8.00, total outline: 3341.37)
- germandbls (U+00DF) contains a short segment Line(Line { p0: (117.0, 520.0), p1: (117.0, 534.0) }) (length: 14.00, total outline: 4227.99)
- f_f_i contains a short segment Quad(QuadBez { p0: (235.0, 626.0), p1: (220.0, 622.0), p2: (213.5, 606.5) }) (length: 30.15, total outline: 5466.07)
- f_f_i contains a short segment Quad(QuadBez { p0: (516.0, 626.0), p1: (501.0, 622.0), p2: (494.5, 606.5) }) (length: 30.15, total outline: 5466.07)
- six (U+0036) contains a short segment Line(Line { p0: (441.0, 523.0), p1: (441.0, 533.0) }) (length: 10.00, total outline: 2886.51)
- nine (U+0039) contains a short segment Line(Line { p0: (149.0, 177.0), p1: (149.0, 167.0) }) (length: 10.00, total outline: 2877.54)
- at (U+0040) contains a short segment Quad(QuadBez { p0: (666.0, 150.0), p1: (666.0, 128.0), p2: (678.0, 115.5) }) (length: 37.47, total outline: 7257.88)
... and 1 others [code: found-short-segments]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
- ℹ️ INFO The family name "Hedvig Letters Sans" seems to be already in use.
Please visit http://namecheck.fontdata.com/ for more info. [code: name-collision]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| HedvigLettersSans-Regular.ttf | |
|---|---|
| Dehinted Size | 61928 |
| Hinted Size | 80828 |
| Increase | 18900 |
| Change | 30.5 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
cvt
fpgm
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.001; ttfautohint (v1.8.4.16-eb64) [code: version-not-detected]
[2] ofl/hedvigletterssans/METADATA.pb
⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (googlefonts/metadata/designer_profiles)
⚠️ WARN It seems that alexanderrn is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
ℹ️ INFO Check METADATA.pb parses correctly (googlefonts/metadata/validate)
- ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]
[1] ofl/hedvigletterssans/DESCRIPTION.en_us.html
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
- ℹ️ INFO Found a git repo URL: https://github.com/KanonFoundry/HedvigLetters [code: url-found]
Summary
| 🔥 FAIL | ℹ️ INFO | ✅ PASS | ⏩ SKIP | |
|---|---|---|---|---|
| 7 | 15 | 12 | 131 | 63 |
| 3% | 7% | 5% | 57% | 28% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken from the upstream repo https://github.com/KanonFoundry/HedvigLetters at commit KanonFoundry/HedvigLetters@d05ac77.
PR Checklist:
PR
QA
Specifics
primary_scriptdefinition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsetsdefinitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong,chinese-simplified,chinese-traditional,korean,japanese.Release
minisite_urldefinition in the METADATA.pb file for commissioned projectstagsare added for NEW FONTS