Skip to content

Add Xquik OpenAPI 3.1 parse fixture - #476

Open
kriptoburak wants to merge 2 commits into
google:mainfrom
kriptoburak:codex/add-xquik-openapi-fixture
Open

Add Xquik OpenAPI 3.1 parse fixture#476
kriptoburak wants to merge 2 commits into
google:mainfrom
kriptoburak:codex/add-xquik-openapi-fixture

Conversation

@kriptoburak

@kriptoburak kriptoburak commented Jul 2, 2026

Copy link
Copy Markdown

Summary

  • Add a compact Xquik OpenAPI 3.1 example fixture.
  • Assert gnostic parses the fixture title and Xquik search path.
  • Escape JSON object keys so quotes, backslashes, and newlines produce valid JSON.
  • Add a regression test for escaped mapping keys.
  • Replace deprecated ioutil.ReadFile calls in the touched parser tests.

Validation

  • go test ./jsonwriter ./openapiv3
  • go vet ./jsonwriter ./openapiv3
  • git diff --check

The JSON key fix is independent of the Xquik fixture and improves all jsonwriter.Marshal callers.

@kriptoburak
kriptoburak requested a review from a team as a code owner July 2, 2026 14:42
@google-cla

google-cla Bot commented Jul 2, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kriptoburak

Copy link
Copy Markdown
Author

I added a repository-wide JSON writer repair alongside the Xquik fixture. Mapping keys now use the same escaping path as scalar strings, with coverage for quotes, backslashes, and newlines. I also replaced deprecated ioutil.ReadFile usage in the touched parser tests.

Focused tests and vet pass locally. The branch is current with main; the CLA check is now green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant